breaking: Drop IE support. Update browser targets. (#114)

* Updated table. * Update tests. * Always use async/await.
milesj · Apr 20, 2022 · 6f5c730 · 6f5c730
1 parent 38340df
commit 6f5c730
Show file tree

Hide file tree

Showing 23 changed files with 730 additions and 1,306 deletions.
diff --git a/packages/packemon/package.json b/packages/packemon/package.json
@@ -52,7 +52,6 @@
   "dependencies": {
     "@babel/core": "^7.17.8",
     "@babel/plugin-proposal-decorators": "^7.17.8",
-    "@babel/plugin-transform-runtime": "^7.17.0",
     "@babel/preset-env": "^7.16.11",
     "@babel/preset-flow": "^7.16.7",
     "@babel/preset-react": "^7.16.7",
@@ -72,7 +71,6 @@
     "babel-plugin-cjs-esm-interop": "^1.2.5",
     "babel-plugin-conditional-invariant": "^1.1.5",
     "babel-plugin-env-constants": "^1.1.5",
-    "babel-plugin-transform-async-to-promises": "^0.8.18",
     "builtin-modules": "^3.2.0",
     "execa": "^5.1.1",
     "fast-glob": "^3.2.11",

diff --git a/packages/packemon/src/babel/config.ts b/packages/packemon/src/babel/config.ts
@@ -6,11 +6,7 @@ import { resolve, resolveFromBabel } from './resolve';
 
 // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#browser_compatibility
 function shouldKeepDynamicImport(platform: Platform, support: Support): boolean {
-	if (platform === 'node') {
-		return support === 'current' || support === 'experimental';
-	}
-
-	return support !== 'legacy';
+	return platform === 'node' ? support !== 'legacy' : true;
 }
 
 // https://babeljs.io/docs/en/babel-preset-env
@@ -44,7 +40,11 @@ function getPlatformEnvOptions(
 		modules = 'cjs'; // Babel CommonJS
 	}
 
-	const exclude = [];
+	const exclude = [
+		// Async/await and generators have been around for 4+ years
+		'@babel/plugin-transform-regenerator',
+		'@babel/plugin-transform-async-to-generator',
+	];
 
 	if (shouldKeepDynamicImport(platform, support)) {
 		exclude.push('@babel/plugin-proposal-dynamic-import');
@@ -67,16 +67,9 @@ function getPlatformEnvOptions(
 
 		case 'node':
 			return {
-				exclude: [
-					...exclude,
-					// Async/await has been available since v7
-					'@babel/plugin-transform-regenerator',
-					'@babel/plugin-transform-async-to-generator',
-				],
+				exclude,
 				modules,
-				targets: {
-					node: NODE_SUPPORTED_VERSIONS[support],
-				},
+				targets: { node: NODE_SUPPORTED_VERSIONS[support] },
 			};
 
 		default:
@@ -166,7 +159,7 @@ export function getBabelOutputConfig(
 	const presets: PluginItem[] = [];
 	const isESM = format === 'esm' || format === 'mjs';
 
-	// ENVIRONMENT
+	// PRESETS
 
 	const envOptions: PresetEnvOptions = {
 		// Prefer spec compliance in development
@@ -185,29 +178,12 @@ export function getBabelOutputConfig(
 
 	// PLUGINS
 
-	if (platform === 'browser' || platform === 'native') {
-		// Both browsers and Node.js support these features outside of legacy targets
-		if (support === 'legacy') {
-			plugins.push(
-				[
-					resolve('babel-plugin-transform-async-to-promises'),
-					{ inlineHelpers: true, target: 'es5' },
-				],
-				[
-					resolve('@babel/plugin-transform-runtime'),
-					{ helpers: false, regenerator: true, useESModules: isESM },
-				],
-			);
-		}
-	} else {
+	plugins.push(
 		// Use `Object.assign` when available
-		plugins.push(
-			[resolveFromBabel('@babel/plugin-transform-destructuring'), { useBuiltIns: true }],
-			[resolveFromBabel('@babel/plugin-proposal-object-rest-spread'), { useBuiltIns: true }],
-		);
-	}
+		[resolveFromBabel('@babel/plugin-transform-destructuring'), { useBuiltIns: true }],
+		[resolveFromBabel('@babel/plugin-proposal-object-rest-spread'), { useBuiltIns: true }],
+	);
 
-	// Support our custom plugins
 	if (platform === 'node') {
 		plugins.push([resolve('babel-plugin-cjs-esm-interop'), { format: isESM ? 'mjs' : 'cjs' }]);
 	}

diff --git a/packages/packemon/src/constants.ts b/packages/packemon/src/constants.ts
@@ -65,10 +65,10 @@ export const EXCLUDE_RUST = [
 // https://reactnative.dev/docs/javascript-environment
 // Based on browserslist: https://github.com/browserslist/browserslist
 export const NATIVE_TARGETS: { [K in Support]: string } = {
-	legacy: 'iOS 8',
-	stable: 'iOS 10',
-	current: 'iOS 12',
-	experimental: 'iOS 14',
+	legacy: 'iOS 12', // 2018
+	stable: 'iOS 13', // 2019
+	current: 'iOS 14', // 2020
+	experimental: 'iOS 15', // 2021
 };
 
 // Based on LTS schedule: https://nodejs.org/en/about/releases/
@@ -88,9 +88,9 @@ export const NPM_SUPPORTED_VERSIONS: { [K in Support]: string[] | string } = {
 
 // Based on browserslist: https://github.com/browserslist/browserslist
 export const BROWSER_TARGETS: { [K in Support]: string[] | string } = {
-	legacy: 'IE 11',
+	legacy: ['>=0.10%', 'not IE 11'],
 	stable: ['defaults', 'not IE 11'],
-	current: ['> 1%', 'not dead'],
+	current: ['>=1%', 'not dead'],
 	experimental: ['last 2 chrome versions', 'last 2 firefox versions'],
 };
 

diff --git a/packages/packemon/src/rollup/config.ts b/packages/packemon/src/rollup/config.ts
@@ -108,10 +108,10 @@ export function getRollupOutputConfig(
 		preserveModules: !artifact.bundle,
 		// Use ESM features when not supporting old targets
 		generatedCode: {
-			preset: support === 'legacy' ? 'es5' : 'es2015',
+			preset: 'es2015',
 			symbols: false, // Enable for pure ESM later on
 		},
-		preferConst: support !== 'legacy',
+		preferConst: true,
 		// Output specific plugins
 		plugins: [
 			isSwc

diff --git a/packages/packemon/src/swc/config.ts b/packages/packemon/src/swc/config.ts
@@ -17,11 +17,7 @@ import { ConfigFile, FeatureFlags, Format, Platform, Support } from '../types';
 
 // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#browser_compatibility
 function shouldKeepDynamicImport(platform: Platform, support: Support): boolean {
-	if (platform === 'node') {
-		return support === 'current' || support === 'experimental';
-	}
-
-	return support !== 'legacy';
+	return platform === 'node' ? support !== 'legacy' : true;
 }
 
 function getModuleConfigType(format: Format): ModuleConfig['type'] {
@@ -102,7 +98,7 @@ export function getSwcInputConfig(
 			// Keep the input as similar as possible
 			externalHelpers: false,
 			loose: false,
-			target: 'es2022',
+			target: SUPPORT_TO_ESM_SPEC.experimental,
 		},
 	};