Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compression/quality level params #735

Closed
SebastienBtr opened this issue May 31, 2021 · 16 comments
Closed

Add compression/quality level params #735

SebastienBtr opened this issue May 31, 2021 · 16 comments
Labels
feature-candidate This issue might result in a feature to be implemented suggestion New feature or request

Comments

@SebastienBtr
Copy link

It would be nice to have some params to choose a desired image quality or compression level on picked medias, the same way it is done on image_picker package with the imageQuality param

@SebastienBtr SebastienBtr added the suggestion New feature or request label May 31, 2021
@miguelpruivo
Copy link
Owner

@SebastienBtr you actually have it with allowCompression flag. Have in mind that imageQuality param in the image_picker applies mostly for camera shots which this plugin doesn’t have, hence, it may not have any purpose.

@SebastienBtr
Copy link
Author

@miguelpruivo Yes I know there is allowCompression but we have no option to control it and choose how much we want to compress and willing to lose in quality. And imageQuality on image_picker applies really well when selecting images in the gallery, you can easily choose the value that makes sense for your use case. For me, it totally makes sense to have the same feature in this package

@dernoun
Copy link

dernoun commented Jul 29, 2021

@miguelpruivo This feature is really wanted specially when we pick and upload an image to the web, it will reduce the image size without loosing the quality and also reduce the upload time.

@SebastienBtr
Copy link
Author

@miguelpruivo I believe this issue should not be closed

@miguelpruivo miguelpruivo reopened this Sep 27, 2021
@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Nov 11, 2021
@github-actions
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@eldarkk
Copy link

eldarkk commented Mar 15, 2022

compression control is needed guys please (at least for images from Gallery)

@miguelpruivo miguelpruivo reopened this Mar 15, 2022
@miguelpruivo
Copy link
Owner

Sorry, I don't have any ETA for this as I've been a bit busy lately. I'll take a look whenever I can.

@miguelpruivo miguelpruivo added feature-candidate This issue might result in a feature to be implemented and removed stale labels Mar 15, 2022
@riveraj33
Copy link

Hello All. I just wanted to see if there was any movement on this? Unfortunately I don't know how to help but adding this is desperately needed. TYIA

@keanallen
Copy link

me too. I wanted that feature ;)

@skully-coder
Copy link

Yes this is needed very much

@harshitha0193
Copy link

any update on this ?

@Umar1312
Copy link

@miguelpruivo I'm working on the PR for this, but I couldn't find any usage of compression on the Android side, there is for iOS though. Am I missing something or it was never implemented on the Android Side.

Thanks

@miguelpruivo
Copy link
Owner

Hi @Umar1312 yes it’s only in the iOS side.

@Umar1312
Copy link

Umar1312 commented Jan 1, 2024

#1426
@miguelpruivo

@miguelpruivo
Copy link
Owner

Merged. Closed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-candidate This issue might result in a feature to be implemented suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants