Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MGTP-Samples-General-Localization-Select a task list-Add a task]: Keyboard Focus loss is observed when user closes 'Task item' by activating 'Close' button using enter/spacebar key. #2304

Closed
vagpt opened this issue May 15, 2023 · 4 comments · Fixed by #3005

Comments

@vagpt
Copy link
Collaborator

vagpt commented May 15, 2023

Test Environment:
OS Build: Windows 11
Version: 22H2 (OS Build 25300.1000)
Browser: Edge dev
Browser Version 114.0.1807.5 (Official build) dev (64-bit)
URL: Components / mgt-agenda / Properties - Preferred Timezone ⋅ Storybook
User ID: V-id

Prerequisites:

  1. Navigate using keyboard only.

Repro Steps:

  1. Open the above URL and login with valid credentials.
  2. 'Microsoft Graph Toolkit Playground' Overview page will get displayed.
  3. Navigate to the 'Components' button using tab key and expand it.
  4. Navigate to 'Samples' button using tab key and expand it.
  5. Navigate to 'General' button using arrow key and expand it.
  6. Navigate to 'Localization' link using arrow key and activate it.
  7. Navigate to 'Select a task list' combo edit field and select 'Task' item from the list.
  8. Navigate to 'Add a task' text field using tab key and type any task name.
  9. Navigate to the 'Close' button using tab key and activate using enter/spacebar key.
  10. Observe where keyboard focus lands.

Actual Result:
Keyboard focus is lost when the user activates the 'Close' button to remove task item using enter/spacebar key.
When the user presses tab, focus lands on the 'Color mode' switch button.

Expected Result:
Keyboard focus should land/retain on 'Add a task' text field when user activates 'Close' button to remove task item.

Note:
This issue is reproducing for all 'Close' buttons present beside 'Add a task' text field throughout application.

Observations:
Focus land on same controls when user press shift tab key after activating Close button using enter/space key.

User Experience:
Keyboard users need to tab unnecessarily on the page whenever user activates 'Close button using enter key Hence the user needs to renavigate back to that text field by pressing tab key several times.

WCAG Reference:
https://www.w3.org/WAI/WCAG21/quickref/?currentsidebar=%23col_overview#focus-order

"Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)

WCAG2.4.3-.Keyboard.focus.is.lost.when.the.user.activates.Close.button.to.remove.task.item.using.enter.spacebar.key.mp4
WCAG2 4 3- Keyboard focus is lost when the user activates 'Close' button to remove task item using enter,spacebar key
@ghost
Copy link

ghost commented May 15, 2023

Hello vagpt, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@gavinbarron gavinbarron moved this from Needs Triage 🔍 to Proposed 💡 in Graph Toolkit May 16, 2023
@vagpt
Copy link
Collaborator Author

vagpt commented Jan 11, 2024

Hi @gavinbarron,

Could you please let us know the ETA to fix this issue as of now issue is still repro?

@sebastienlevert
Copy link
Contributor

A lot of improvements are currently in flight for this component (To Do). On https://mgt.dev/next this still reproes though.

@sebastienlevert sebastienlevert moved this from Proposed 💡 to Todo 📃 in Graph Toolkit Jan 11, 2024
@Mnickii Mnickii added this to the Engineering backlog milestone Jan 29, 2024
@musale musale moved this from Todo 📃 to In Review 💭 in Graph Toolkit Jan 31, 2024
@musale musale self-assigned this Jan 31, 2024
@vagpt
Copy link
Collaborator Author

vagpt commented Feb 2, 2024

This issue is working fine on the environment below, hence closing this issue. Attachment is added for the reference.

Test Environment:
OS Build: Windows 11
Version: 23H2 (OS Build 26040.1000)
Browser: Edge dev
Browser Version 122.0.2386.3 (Official build) dev (64-bit)
URL: https://mgt.dev/next/pr/3005/?path=/story/samples-general--localization
User ID: V-id

Issue.is.fixed.on.MGTP.mp4

@vagpt vagpt closed this as completed Feb 2, 2024
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Graph Toolkit Feb 2, 2024
@Raisul123 Raisul123 added the MicrosoftGraphToolkitPlayground_Web fetch bug data from the db for accessibility label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment