Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than one manifest per PR #842

Closed
KevinLaMS opened this issue May 14, 2020 · 3 comments
Closed

Support more than one manifest per PR #842

KevinLaMS opened this issue May 14, 2020 · 3 comments
Milestone

Comments

@KevinLaMS
Copy link
Contributor

Description of the new feature/enhancement

Today in order to submit a PR for a manifest, I can only do 1 at a time. This is inefficient. I would like to be able to have the ability to submit multiple Manifests in one PR.

For example if I am adding a new application, I may have one or more older builds I want to submit. See Windows SDK for example:
17134, 17763, 19041, 18362

Or maybe I have multiple projects that release at one time like a suite, and each app would have its own manifest. I should be able to submit them all.

Proposed technical implementation details (optional)

I expect a submission to process each manifest individually. This should be treated like a normal PR. If the full submission does not pass, it is OK to fail the submission. Similar to code. However the BOT should communicate which manifest failed an why.

If the submission passes, then all manifests should be ingested.

@denelon
Copy link
Contributor

denelon commented May 16, 2020

#125

@denelon denelon changed the title Support Multiple manifests in one PR Support more than one manifest per PR May 16, 2020
@denelon denelon transferred this issue from microsoft/winget-cli May 23, 2020
@denelon
Copy link
Contributor

denelon commented Jun 1, 2020

Duplicate of #125

@denelon denelon marked this as a duplicate of #125 Jun 1, 2020
@ghost
Copy link

ghost commented Jun 1, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jun 1, 2020
@ghost ghost added the duplicate label Jun 1, 2020
@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants