Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify community members that usually update specific packages. #29323

Open
denelon opened this issue Oct 4, 2021 · 7 comments
Open

Identify community members that usually update specific packages. #29323

denelon opened this issue Oct 4, 2021 · 7 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.

Comments

@denelon
Copy link
Contributor

denelon commented Oct 4, 2021

I like the idea of having designated community members that usually update specific packages. Some people here know a lot about how certain apps install (Visual Studio and Python are two example off the top of my head) and it would be nice to have that written down somewhere. Not to pin responsibility on anyone, of course (anyone can open a PR for anything they want presuming the ISV hasn't claimed the ID), but having a designated .package or .maintainer file that says "@jedieaston knows about this, mention them in issues" wouldn't be a bad idea.

Chocolatey has something similar, see the "Package Maintainers" section to the left of this page.

Originally posted by @jedieaston in #29258 (comment)

@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Oct 4, 2021
@denelon
Copy link
Contributor Author

denelon commented Oct 4, 2021

I'm not sure how we would go about this, but it is interesting. Maybe we could mention previous authors for manifests/packages when a PR is created.

@denelon denelon added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Oct 4, 2021
@Trenly
Copy link
Contributor

Trenly commented Oct 4, 2021

I love this idea. I also think it would be great to include it for some of the other files in the repository such as the files in /Tools or even the pipeline definitions.

I think mentions would be good, but this could also be used for package-level moderation, where if a user is a maintainer of a package, they are able to approve requests for that package only.

@kdpuvvadi
Copy link
Contributor

And something like bot Mentioning of mod if someone opens an issue regarding that package?

@lychichem
Copy link
Contributor

Agree as tencent.wechat always have issues when autoupdate was performed and need someone to investigate. I and other maintainers will be glad to see this change.

@Trenly
Copy link
Contributor

Trenly commented Oct 6, 2021

Agree as tencent.wechat always have issues when autoupdate was performed and need someone to investigate. I and other maintainers will be glad to see this change.

This could also be used as an indicator to the bot to skip auto-updating of these files and instead only create issues, especially for packages like Calibre where we know there are issues with automatic updates.

@Biztactix-Ryan
Copy link

I think new people should be flagged for manual review, with existing people having less scrutiny,
I see the fact that anyone can issue a PR to be quite a security issue, especially if this starts getting the use that the community wants.
There are numerous was to subvert an installer URL that looks plausible on a cursory glance. Having any new contributor require greater scrutiny would be 1 step to providing some security

@Trenly
Copy link
Contributor

Trenly commented Jan 31, 2022

I think new people should be flagged for manual review, with existing people having less scrutiny,
I see the fact that anyone can issue a PR to be quite a security issue, especially if this starts getting the use that the community wants.
There are numerous was to subvert an installer URL that looks plausible on a cursory glance. Having any new contributor require greater scrutiny would be 1 step to providing some security

All urls are scanned with multiple antivirus providers, and every package hash is also validated. On top of that, every PR has to be approved by one of the community moderators after they test the package on one (or more) virtual machines to ensure that the package is exactly what the submitter is claiming it to be. So the actual risk of a malicious application making it into the repository is actually very low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

No branches or pull requests

5 participants