-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade --all getting ignored / failing #1985
Comments
Can you run |
The log is 76k lines so I uploaded it here: |
Decided to try running the command again today:
As can be seen, one of the packages that previously refused to update (Geforce Now) went through this time. Of note is a new troublesome package (Tachidesk) which supposedly updates "successfully", but still shows up as outdated afterward. I do not like how inconsistent things are. |
This appears to be an issue with the installer. I'm wondering if installing Tachidesk Server 0.6.2 on a clean system reports the right version in Windows Apps & Features. If it does then the next question would be if having 0.6.1 and running 0.6.2 as an upgrade updates the entry, or if it installs a "new" version side by side. Running Maybe there are switches we need to pass to get the string updated, or we need to change the upgrade behavior to "uninstallPrevious" in the manifest. |
Awesome community for the win! |
I believe this may be an issue with GeForce Now reporting a successful install but not actually installing if the application is currently in use / running
Your issue with VeraCrypt is that the installation currently on your machine was installed with the exe file, and the version in winget uses the MSI file. The easiest way to fix this is to uninstall your current version and re-install. I can replicate this using version 1.1 of the client. Using version 1.2 of the client I get this message -
|
To answer your other questions:
If you find any other unresolved package issues you can report them here https://github.com/microsoft/winget-pkgs/issues/new/choose |
Slight correction - There is an exe available here . I just can't seem to find the secret combination of switches for a silent install |
Ops, just looked up my previous comment on VeraCrypt
Chocolatey uses AHK for the installation so there is probably a very low chance you'll find the magic switch Edit: we could make a issue here? https://github.com/veracrypt/VeraCrypt/issues |
|
We need to be cautious about adding that switch to the manifest. It's better for them to either publish to the Microsoft Store or become a verified developer so we can include Agreements in the manifest to meet the "explicit" agreement requirements. |
So far as I can tell, it is just the EULA which that switch suppresses, which often happens with any installer which incorporates the EULA agreement into the install process. Its just that many publishers allow the eula to be suppressed with the default silent switch rather than requiring an additional switch |
So PowerToys is not updating because of installer type change, not because it sees I'm on 1809 (an unsupported Windows build)? Also is there a reason an exe can't "gracefully" be updated into an msi and visa versa? |
The InstallerType changed in version
Most of the time the MSI and EXE can be installed side-by-side or work differently
if you do In the future you will be asked if you want to force upgrade (will probably uninstall and install the new version) |
I see. |
Brief description of your issue
Winget sees that there are upgrades but..
upgrade --all
.Installer hash does not match
.Could be related to the recent Nvidia breach?
Note: PowerToys isn't supposed to upgrade because they only support above 1809, and I'm on 1809, so that behavior is correct.
Steps to reproduce
Run
winget upgrade --all --source winget
.Expected behavior
All packages are updated except for the unsupported ones by the system.
Actual behavior
Some packages are ignored, others fail.
Environment
The text was updated successfully, but these errors were encountered: