Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with packages which provide different ID for different locales #1162

Closed
lychichem opened this issue Jun 12, 2021 · 5 comments
Closed

Deal with packages which provide different ID for different locales #1162

lychichem opened this issue Jun 12, 2021 · 5 comments
Labels
Issue-Feature This is a feature request for the Windows Package Manager client. Resolution-Duplicate Issue is a duplicate
Milestone

Comments

@lychichem
Copy link

Description of the new feature/enhancement

Deal with packages which provide different ID for different locales

Proposed technical implementation details (optional)

Provide a system that can link packages with identical downloadurl (or other things, now I have no idea for other things) but will provide different ID for different locales. An example for this situation is microsoft/winget-pkgs#17085 , now alibaba.dingtalk will register itself as 钉钉 for Chinese users and dingtalk for foregin users. Maybe youdao.youdaodict is the same, but I've never tested it on an English machine.

@OfficialEsco
Copy link

It might actually support different PackageID's since its in the manifest metadata, but we can't test this yet because PR's ain't getting approved 😴

@OfficialEsco
Copy link

Oke, give it an hour then you can start testing if it detects it (do winget source update to be sure)

@denelon
Copy link
Contributor

denelon commented Jun 14, 2021

This should be covered in #1073

@denelon denelon transferred this issue from microsoft/winget-pkgs Jun 14, 2021
@ghost ghost added the Needs-Triage Issue need to be triaged label Jun 14, 2021
@denelon denelon added Issue-Feature This is a feature request for the Windows Package Manager client. and removed Needs-Triage Issue need to be triaged labels Jun 14, 2021
@denelon
Copy link
Contributor

denelon commented Jun 14, 2021

Duplicate of #1073

@denelon denelon marked this as a duplicate of #1073 Jun 14, 2021
@ghost
Copy link

ghost commented Jun 14, 2021

@lychichem we've identified this Issue as a duplicate of another one that already exists. This specific instance is being closed in favor of tracking the concern over on the referenced Issue. Thanks for your report! Be sure to add your 👍 to the other issue to help raise the priority.

@ghost ghost closed this as completed Jun 14, 2021
@ghost ghost added the Resolution-Duplicate Issue is a duplicate label Jun 14, 2021
@denelon denelon added this to the v1.3-Client milestone Jun 21, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client. Resolution-Duplicate Issue is a duplicate
Projects
None yet
Development

No branches or pull requests

3 participants