-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several problems are being caused by the new log file name timestamp #1978
Comments
@jnm2 we are looking at this issue, & re-designing on how we should handle the results at dotnet sln(multiple test project / multi target test project) level. We are not reverting the fix done earlier immediately, as it might cause confusion for those whose trx are getting published. We will publish an RFC once we have a design in place, before implementing it. |
Good to know. I'd love if there was a way for the TRX format to be enhanced so that a single file can contain all the results for each target framework. Projects that use TRX would be able to follow the Second-best would be |
well maybe you could use the existing feature? --logger "rx;LogFileName=Core2_1.trx" for Core 2.1 --logger "rx;LogFileName=Core2_2.trx" for Core 2.2 this change broke all of my multi-targeted builds! |
How would my build script know which TFMs to use? They change pretty often. This is additional pain. |
@vagisha-nidhi Can you please link the RFC for this fix and also release when it is available. |
Tagging @AbhitejJohn |
#1877 was reverted in #1996 so that fixes the log file name timestamp part of the issue. Being able to run tests on multiple frameworks and collect the results is unfortunately not yet solved, though. See also #1876 which is related to this issue. If the |
Note to self: test if problem still exists |
Cross-posting my comment from #1876 which can workaround this issue by defining the test logger parameters as MSBuild properties, where you have access to the target framework and the project name. I recently learnt that you can control the loggers through MSBuild properties instead of <ItemGroup>
<VSTestLogger Include="trx%3BLogFileName=TestResults-$(TargetFramework)-$(MSBuildProjectName).trx" />
<VSTestLogger Include="html%3BLogFileName=TestResults-$(TargetFramework)-$(MSBuildProjectName).html" />
</ItemGroup>
<PropertyGroup Condition="$(ContinuousIntegrationBuild) == 'true'">
<VSTestResultsDirectory>$(MSBuildThisFileDirectory)\..</VSTestResultsDirectory>
<VSTestLogger>@(VSTestLogger)</VSTestLogger>
</PropertyGroup> |
Workaround is provided. |
#1877 is causing problems.
The text was updated successfully, but these errors were encountered: