Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VsTestConsoleWrapper.CancelDiscovery is not implemented #149

Closed
genlu opened this issue Oct 20, 2016 · 7 comments
Closed

VsTestConsoleWrapper.CancelDiscovery is not implemented #149

genlu opened this issue Oct 20, 2016 · 7 comments

Comments

@genlu
Copy link
Member

genlu commented Oct 20, 2016

It'd be nice to be able to cancel test discovery when LUT is paused or discovery hangs due to bugs in test platform/test adapter/test framework.

Also, behavioral wise, I think it'd make sense to let CancelDiscovery to immediately abort current discovery, kill testhost process and cause the call to DiscoverTests to return (with isAbortedset to true). @saikrishnav Does this sound reasonable?

@pvlakshm
Copy link
Contributor

Closing this; reactivate if still required.

@AbhitejJohn AbhitejJohn reopened this May 24, 2019
@AbhitejJohn
Copy link
Contributor

AbhitejJohn commented May 24, 2019

I've gone ahead and reopened this issue. It would be really great to have a form of discovery cancellation where other high priority operations need to supersede a currently running potentially long discovery operation. For instance a build/rebuild/clean operation or a solution close.

From an implementation standpoint if I understand this correctly it could probably just be killing the testhost process.
/cc: @cltshivash

@cltshivash cltshivash assigned cltshivash and unassigned singhsarab Jun 19, 2019
@ManishJayaswal
Copy link

@cltshivash - any update on this issue?

@cltshivash
Copy link
Contributor

@ManishJayaswal The changes are in and we should be inserting the TP version with the fix for 16.3 this week.

@ManishJayaswal
Copy link

@cltshivash great to hear this!

@AbhitejJohn
Copy link
Contributor

@cltshivash : I just tried this out on a solution with 100,000 MSTest tests -> Closed solution while discovery is still in progress but that did not stop the operation. It looks like we bail out from discovery between adapter calls but if an adapter is still servicing a request, there isn't a way of hard-stopping it. That's probably a change in the adapter interface but until that is fixed, we could probably use a testhost process kill similar to AbortTestRun. That should fix the scenario above for us.

@singhsarab
Copy link
Contributor

This should be resolved by #2076 and #2134

@Sanan07 Sanan07 closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants