-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VsTestConsoleWrapper.CancelDiscovery
is not implemented
#149
Comments
Closing this; reactivate if still required. |
I've gone ahead and reopened this issue. It would be really great to have a form of discovery cancellation where other high priority operations need to supersede a currently running potentially long discovery operation. For instance a build/rebuild/clean operation or a solution close. From an implementation standpoint if I understand this correctly it could probably just be killing the testhost process. |
@cltshivash - any update on this issue? |
@ManishJayaswal The changes are in and we should be inserting the TP version with the fix for 16.3 this week. |
@cltshivash great to hear this! |
@cltshivash : I just tried this out on a solution with 100,000 MSTest tests -> Closed solution while discovery is still in progress but that did not stop the operation. It looks like we bail out from discovery between adapter calls but if an adapter is still servicing a request, there isn't a way of hard-stopping it. That's probably a change in the adapter interface but until that is fixed, we could probably use a testhost process kill similar to AbortTestRun. That should fix the scenario above for us. |
It'd be nice to be able to cancel test discovery when LUT is paused or discovery hangs due to bugs in test platform/test adapter/test framework.
Also, behavioral wise, I think it'd make sense to let
CancelDiscovery
to immediately abort current discovery, kill testhost process and cause the call to DiscoverTests to return (with isAborted
set to true). @saikrishnav Does this sound reasonable?The text was updated successfully, but these errors were encountered: