Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom TestAdapterPath XML element should be "TestAdapterPaths", but NOT "TestAdaptersPaths" #141

Closed
saikrishnav opened this issue Oct 18, 2016 · 5 comments
Labels

Comments

@saikrishnav
Copy link
Member

saikrishnav commented Oct 18, 2016

Description

From command line, we do: /testadapterpath: "<PathToAdapter">
From RunSettings: we should do: <TestAdapterPaths>
since we can specify more than one path there.

Currently we are expecting "TestAdaptersPaths" - which is not consistent and not intuitive.

Change this to "TestAdapterPaths" in RunConfiguration

@codito
Copy link
Contributor

codito commented Oct 18, 2016

Unfortunately this will be a breaking change for xml schema. @pvlakshm thoughts?

@pvlakshm pvlakshm added bug and removed question labels Nov 28, 2016
@pvlakshm
Copy link
Contributor

Triage: Support both, Do not break compat.

@saikrishnav
Copy link
Member Author

I think it is OK to have the old name. Unnecessary confusion otherwise. Closing this for now.
@codito - Please reopen if you think you want to add anything here. I do not see anything required here.

@AbhitejJohn
Copy link
Contributor

There is however a disparity in this naming: The runsettings uses "TestAdaptersPaths" and the commandline accepts testadapterpath. Should we not have the same naming here? IIRC the commandline testadapterpath argument does not take in multiple paths which is another gap.

@smadala
Copy link
Contributor

smadala commented Dec 6, 2017

Not changing name for compact reasons. Gap is addressed by @dtretyakov #1320,

@smadala smadala closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants