-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom TestAdapterPath XML element should be "TestAdapterPaths", but NOT "TestAdaptersPaths" #141
Comments
Unfortunately this will be a breaking change for xml schema. @pvlakshm thoughts? |
Triage: Support both, Do not break compat. |
I think it is OK to have the old name. Unnecessary confusion otherwise. Closing this for now. |
There is however a disparity in this naming: The runsettings uses "TestAdaptersPaths" and the commandline accepts testadapterpath. Should we not have the same naming here? IIRC the commandline testadapterpath argument does not take in multiple paths which is another gap. |
Not changing name for compact reasons. Gap is addressed by @dtretyakov #1320, |
Description
From command line, we do: /testadapterpath: "<PathToAdapter">
From RunSettings: we should do:
<TestAdapterPaths>
since we can specify more than one path there.
Currently we are expecting "TestAdaptersPaths" - which is not consistent and not intuitive.
Change this to "TestAdapterPaths" in RunConfiguration
The text was updated successfully, but these errors were encountered: