Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: Toggling workbench.editor.showTabs setting clears pinned state #99090

Closed
joaomoreno opened this issue Jun 2, 2020 · 2 comments
Closed

Tabs: Toggling workbench.editor.showTabs setting clears pinned state #99090

joaomoreno opened this issue Jun 2, 2020 · 2 comments
Assignees
@bpasero
Labels
info-needed Issue requires more information from poster workbench-tabs VS Code editor tab issues

Comments

@joaomoreno
Copy link
Member

Related to #98019

I toggled the workbench.editor.showTabs and it cleared the pinned state, I wasn't expecting it to happen.
@bpasero
Copy link
Member

bpasero commented Jun 2, 2020

@joaomoreno yeah doing that explicitly because we have no visual indication that a tab is pinned when you have tabs disabled. In general this feature requires tabs to work. Are you suggesting it should work with tabs disabled?

@bpasero bpasero added info-needed Issue requires more information from poster workbench-tabs VS Code editor tab issues labels Jun 2, 2020
@joaomoreno
Copy link
Member Author

No not really, just if it's low hanging. I don't think it's a useful scenario, let's close it.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
info-needed Issue requires more information from poster workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaomoreno @bpasero