Moving a pinned editor unpins it

[joaomoreno]

Testing #98019

Drag a pinned tab and drop it on a tab bar empty space. I expected it to remain pinned. 🤷

[bpasero]

@joaomoreno can you clarify, do you only have 1 pinned tab? In general, moving a pinned tab after the last tab will unpin it if that last tab is unpinned.

[joaomoreno]

In general, moving a pinned tab after the last tab will unpin it if that last tab is unpinned.

You seem to distinguish between the last tab of the drop container being pinned or not, despite the fact that I'm not dropping on top of the last tab of the container, but on the container itself. As a user, this doesn't make much sense, since my perception is that I'm dragging a pinned tab onto a container, so it should remain pinned, independently of what the state of the last tab of that container is.

POWERED BY GIFCAP

[bpasero]

Well, my argument is that you are dropping a tab after an existing tab of a tab group. Now I am in conflict: should the tab be pinned or should it be after the last tab. Pinned tabs cannot be after unpinned tabs (currently), so I can either respect the index of the tab (which I prefer) or the pinned state.

Given comments such as #99035 (comment) I think preserving the pinned state is maybe not what we should do in many cases.

[joaomoreno]

Isn't a split different than a drag and drop? 🤔

[bpasero]

Yeah, fair point. Again, I am preferring to preserve the index, not the pinned state here. If you drop into an empty group, I preserve pinned state.

[joaomoreno]

@bpasero 🙈

POWERED BY GIFCAP

Now seriously, I'm not sure the index is the thing to preserve here. Tabs are not pinned because their index is lower than the first non-pinned tab index... they are pinned because I pinned them. Their position and their state should be two independent things, right?

[bpasero]

@joaomoreno well that is just how Chrome behaves. I decided to do what Safari does which allows you to easily drag/drop tabs in and out of pinning state (which is something I heard from users is good to have).

I argue Chrome is artificially limiting the DND experience when a tab is pinned.