Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS color completion doesn't show color sample #68269

Closed
chrisdias opened this issue Feb 8, 2019 · 5 comments
Closed

CSS color completion doesn't show color sample #68269

chrisdias opened this issue Feb 8, 2019 · 5 comments
Assignees
@jrieken @octref
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone
February 2019

Comments

@chrisdias
Copy link
Member

Reported on twitter

  • MacOS
  • open a CSS file
  • press # to bring up color completions

result: in 1.31.0 we don't see the color preview

1.30.2

image

1.31.0
image
@csgrant83
Copy link

Same problem, except I am on Windows 10

@octref
Copy link
Contributor

octref commented Feb 12, 2019

@jrieken Any idea? Seems #67029 wasn't verified since we forgot to add it to milestone.

@octref octref added the bug Issue identified by VS Code Team member as probable bug label Feb 12, 2019
@jrieken jrieken added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug labels Feb 13, 2019
@jrieken
Copy link
Member

jrieken commented Feb 13, 2019

screenshot 2019-02-13 at 08 37 06

doesn't reproduce for me. @octref steps? settings?

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Feb 13, 2019
@jrieken
Copy link
Member

jrieken commented Feb 13, 2019

Ha, you need to get a hex value proposed. Didn't know we support that. @octref feel free to investigate and fix. This feature is has been added for css only and I think its fair if css maintains it

@octref octref added this to the February 2019 milestone Feb 13, 2019
@usernamehw usernamehw mentioned this issue Feb 14, 2019
Closed
@jrieken jrieken added the suggest IntelliSense, Auto Complete label Feb 14, 2019
@jrieken
Copy link
Member

jrieken commented Feb 14, 2019

Muahaha, I think we broken this feature three times with strict-null-works. I am confident this time it's better 🤞

@mjbvz mjbvz added the verified Verification succeeded label Feb 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@octref octref

Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
6 participants
@rebornix @chrisdias @jrieken @octref @mjbvz @csgrant83