Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename stops at destructuring #66547

Closed
cdeutsch opened this issue Jan 15, 2019 · 2 comments
Closed

Rename stops at destructuring #66547

cdeutsch opened this issue Jan 15, 2019 · 2 comments
Assignees
@mjbvz
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-contrib Editor collection of extras javascript JavaScript support issues typescript Typescript support issues

Comments

@cdeutsch
Copy link

  • VSCode Version: 1.30.2 (1.30.2)
  • OS Version: macOS 10.14.2 (18C54)

Steps to Reproduce:

  1. Rename a variable and it stops at any destructuring.

jan-15-2019 09-45-42

Does this issue occur when all extensions are disabled?: Yes

This behavior was recently changed:
https://code.visualstudio.com/updates/v1_30#_renames-handle-jsts-destructuring-properly

It makes sense if you're doing the rename at the point of destructuring, but when making it "above" the point of destructuring it doesn't.

I'd request to support both scenarios, or add a flag to turn off the updated rename so it works like the previous version.
@vscodebot
Copy link

vscodebot bot commented Jan 15, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the editor-contrib Editor collection of extras label Jan 15, 2019
@mjbvz mjbvz self-assigned this Jan 15, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 15, 2019 •
edited
Loading

Duplicate of #65518 (microsoft/TypeScript#29238)

@mjbvz mjbvz closed this as completed Jan 15, 2019
@mjbvz mjbvz added typescript Typescript support issues javascript JavaScript support issues *duplicate Issue identified as a duplicate of another issue(s) labels Jan 15, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-contrib Editor collection of extras javascript JavaScript support issues typescript Typescript support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdeutsch @mjbvz