Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color completions showing generic icon #63062

Closed
mjbvz opened this issue Nov 13, 2018 · 4 comments
Closed

Color completions showing generic icon #63062

mjbvz opened this issue Nov 13, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 13, 2018

Issue Type: Bug

Repo

  1. In a css file:
.a {
    color: r|
}
  1. Trigger completions at the |

Bug
Suggestions for colors like red have a generic color icon instead of the actual color:

screen shot 2018-11-13 at 3 06 40 pm

VS Code version: Code - Insiders 1.30.0-insider (c72cb12, 2018-11-13T06:12:08.651Z)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 5, 4, 3
Memory (System) 16.00GB (0.13GB free)
Process Argv --disable-extensions
Screen Reader no
VM 22%
Extensions disabled
@mjbvz
Copy link
Collaborator Author

mjbvz commented Nov 13, 2018

This line is failing: https://github.com/microsoft/vscode/blob/master/src/vs/editor/contrib/suggest/suggestWidget.ts#L160

suggestion.documentation is a markdown string here, not a string

@octref
Copy link
Contributor

octref commented Nov 13, 2018

Color codes show up fine for me, named colors don't. I guess it's related to changes in suggest widget.

@octref octref added the suggest IntelliSense, Auto Complete label Nov 13, 2018
@octref octref assigned jrieken and unassigned octref and aeschli Nov 13, 2018
@octref
Copy link
Contributor

octref commented Nov 13, 2018

image

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Nov 14, 2018
@jrieken
Copy link
Member

jrieken commented Nov 14, 2018

This is a regression from us making things more markdown'ish by default...

@Tyriar Tyriar added the verified Verification succeeded label Dec 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants