Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Rename symbol" when instance property is assigned to itself does not work #57456

Closed
garyking opened this issue Aug 28, 2018 · 4 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@garyking
Copy link

  • VSCode Version: Version 1.26.1 (1.26.1)
  • OS Version: Mac 10.13.5 (17F77)

Steps to Reproduce:

  1. Use the following code:
class Test {
  constructor() {
    this.a = this.a.bind(this);
  }

  a() {
    return 'a';
  }
}
  1. With the cursor on the a in a(), run "Rename symbol", and rename it to something else. The symbol in this.a = will not rename.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Aug 28, 2018
@dbaeumer dbaeumer added typescript Typescript support issues and removed editor editor-contrib Editor collection of extras labels Aug 29, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 4, 2018

I can't repo using VS Code insiders with TypeScript 3.0.1 (the bundled version of TypeScript):

sep-04-2018 11-44-43

Please provide more information about your project setup. Have you configured the typescript.tsdk setting?

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Sep 4, 2018
@garyking
Copy link
Author

garyking commented Sep 5, 2018

I reproduced with the latest Insiders, all default settings, no project settings, just a folder with one file.

rename symbol

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 5, 2018

Thanks. Upon further investigation, this issue is a duplicate of microsoft/TypeScript#18171

@mjbvz mjbvz closed this as completed Sep 5, 2018
@mjbvz mjbvz added upstream Issue identified as 'upstream' component related (exists outside of VS Code) *duplicate Issue identified as a duplicate of another issue(s) and removed info-needed Issue requires more information from poster labels Sep 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants