You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jrieken removed this morning the Logger API via 1c72ab2
This casued debugging to no longer work - just start debugging and you would get an exception (out of source).
The issue is that node-debug2 depends on the Logger which is proposed api. There are alternative solutions which we could use.
Also adding @weinand in case he is using the Logger in his extensions
Assigning to August since we should tackle this this week hopefully. If you do not have time let me know and I can look into it.
Once this is done, @jrieken can remove the Logger, for now we have reverted the change that removes the Logger
The text was updated successfully, but these errors were encountered:
Since the plan is to move the logger API from the extensionContext to the output channel, we'll have to wait for this adoption until the API becomes available at the new location.
@roblourens are you taking care of moving your old Logger API to the output channel?
weinand
changed the title
Do not use Logger
Do not use proposed logger API
Aug 17, 2018
weinand
changed the title
Do not use proposed logger API
Do not use deprecated logger API
Aug 17, 2018
Node2 doesn't use that logger API. We have our own logger that runs in the DA and writes to a file. We only use the logDirectory property which is becoming stabilized.
@jrieken removed this morning the
Logger
API via 1c72ab2This casued debugging to no longer work - just start debugging and you would get an exception (out of source).
The issue is that node-debug2 depends on the Logger which is proposed api. There are alternative solutions which we could use.
Also adding @weinand in case he is using the Logger in his extensions
Assigning to August since we should tackle this this week hopefully. If you do not have time let me know and I can look into it.
Once this is done, @jrieken can remove the Logger, for now we have reverted the change that removes the
Logger
The text was updated successfully, but these errors were encountered: