Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use deprecated logger API #56658

Closed
isidorn opened this issue Aug 17, 2018 · 5 comments
Closed

Do not use deprecated logger API #56658

isidorn opened this issue Aug 17, 2018 · 5 comments
Assignees
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 17, 2018

@jrieken removed this morning the Logger API via 1c72ab2
This casued debugging to no longer work - just start debugging and you would get an exception (out of source).

The issue is that node-debug2 depends on the Logger which is proposed api. There are alternative solutions which we could use.
Also adding @weinand in case he is using the Logger in his extensions

Assigning to August since we should tackle this this week hopefully. If you do not have time let me know and I can look into it.
Once this is done, @jrieken can remove the Logger, for now we have reverted the change that removes the Logger

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues debt Code quality issues labels Aug 17, 2018
@isidorn isidorn added this to the August 2018 milestone Aug 17, 2018
@weinand
Copy link
Contributor

weinand commented Aug 17, 2018

Both node debuggers use the proposed logger API.

@jrieken has already reverted the removal.

Since the plan is to move the logger API from the extensionContext to the output channel, we'll have to wait for this adoption until the API becomes available at the new location.

@roblourens are you taking care of moving your old Logger API to the output channel?

@weinand weinand changed the title Do not use Logger Do not use proposed logger API Aug 17, 2018
@weinand weinand changed the title Do not use proposed logger API Do not use deprecated logger API Aug 17, 2018
@jrieken
Copy link
Member

jrieken commented Aug 17, 2018

we'll have to wait for this adoption until the API becomes available at the new location.

You can use appendLine already today

@roblourens
Copy link
Member

Node2 doesn't use that logger API. We have our own logger that runs in the DA and writes to a file. We only use the logDirectory property which is becoming stabilized.

@roblourens
Copy link
Member

roblourens commented Aug 17, 2018

@weinand
Copy link
Contributor

weinand commented Aug 17, 2018

@jrieken I've moved node-debug off the Logger API and node-debug no longer uses proposed API.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

4 participants