Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnemonics in the custom menus are using a different font #55681

Closed
aeschli opened this issue Aug 2, 2018 · 2 comments · Fixed by #56617
Closed

Mnemonics in the custom menus are using a different font #55681

aeschli opened this issue Aug 2, 2018 · 2 comments · Fixed by #56617
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 2, 2018

Elementary Loki (Ubuntu 16.04)

Version: 1.26.0-insider
Commit: c86cab2
Date: 2018-08-02T05:18:18.450Z

image

  • the right arrow for the sub menus is too prominent. A little smaller would be more elegant
  • the checkmark (see Auto Save) is barely visible
  • the characters with mnemonice seem to use a different font (e.g. see thel in Save All)
  • the submenus upper left corner seems to be round, while other corners are not
  • the black menu on the back background is hard to see. On ElementaryOS the menu background color is normally white, which works quite well. Maybe it would make sense to read out the OS colors?
@sbatten
Copy link
Member

sbatten commented Aug 8, 2018

Most of these have their own issues. I will rename as I think one does not.

The roundedness of the top left is an illusion. This is much more obvious in a light theme. As for the color, the menus are themable so this is user choice.

@sbatten sbatten changed the title Custom menu: Some small UI glitches Mnemonics in the custom menus are using a different font Aug 8, 2018
@sbatten sbatten added the bug Issue identified by VS Code Team member as probable bug label Aug 8, 2018
@sbatten sbatten added this to the August 2018 milestone Aug 8, 2018
@be5invis
Copy link
Contributor

Also repros on Windows
image

@roblourens roblourens added the verified Verification succeeded label Aug 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants