Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title bar font glitch in Chinese locale when titleBarStyle is set to custom #54232

Closed
CallMeR opened this issue Jul 13, 2018 · 3 comments · Fixed by #56617
Closed

Title bar font glitch in Chinese locale when titleBarStyle is set to custom #54232

CallMeR opened this issue Jul 13, 2018 · 3 comments · Fixed by #56617
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2018

Comments

@CallMeR
Copy link

CallMeR commented Jul 13, 2018

  • VSCode Version: 1.25.1
  • OS Version: Deepin 15.6

Steps to Reproduce:

  1. Change language to Chinese SImplified.
  2. Add "window.titleBarStyle": "custom", to settings.
  3. Toggle the title bar.

image

Does this issue occur when all extensions are disabled?: Yes
@CallMeR
Copy link
Author

CallMeR commented Jul 16, 2018

fonts fallback?

@vscodebot vscodebot bot removed the new release label Jul 16, 2018
@sbatten sbatten added the bug Issue identified by VS Code Team member as probable bug label Jul 16, 2018
@sbatten sbatten added this to the July 2018 milestone Jul 16, 2018
@CallMeR
Copy link
Author

CallMeR commented Jul 19, 2018

And in Windows 10 ,the Chinese Font rendering seems indistinct.
Just like this:
image

@sbatten sbatten modified the milestones: July 2018, August 2018 Jul 30, 2018
@lyhzh
Copy link

lyhzh commented Aug 6, 2018

@sbatten
This should be because the secondary menu and the right-click menu are still using the global default font, and there is no inherited font used when the language is Chinese.
这应该是因为二级菜单和右键菜单仍在使用全局默认的字体,没有继承语言是中文时所使用的字体,

@CallMeR
字体模糊不清已经在 #53672 通过加大字体的方法解决了😂
The illegibility of the font has been solved by enlarging the font in #53672 .

@sbatten sbatten mentioned this issue Aug 17, 2018
Merged
@roblourens roblourens added the verified Verification succeeded label Aug 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2018
Development

Successfully merging a pull request may close this issue.

new mnemonics behavior microsoft/vscode
5 participants
@roblourens @Tyriar @sbatten @CallMeR @lyhzh