Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus are showing underscores in the menu entries #53767

Closed
LordHog opened this issue Jul 7, 2018 · 8 comments · Fixed by #56617
Closed

Menus are showing underscores in the menu entries #53767

LordHog opened this issue Jul 7, 2018 · 8 comments · Fixed by #56617
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux verified Verification succeeded
Milestone

Comments

@LordHog
Copy link

LordHog commented Jul 7, 2018

In VSC 1.25 there are underscores in the menu names. I think these indicate a letter should be underlined indicating it is a hotkey. I see this on CentOS 7 machine and not my Windows 10 machine. Need to check at home and see what Windows 7 shows.

vsc_1 25_menu_underscrores

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-menu linux Issues with VS Code on Linux labels Jul 7, 2018
@sbatten sbatten added this to the July 2018 milestone Jul 10, 2018
@sbatten
Copy link
Member

sbatten commented Jul 29, 2018

@LordHog I couldn't repro this on my Ubuntu machine. I finally got around to installing CentOS 7 but still could not repro this issue. Can you provide more specific info on your centOS version and setup?

@sbatten sbatten added the info-needed Issue requires more information from poster label Jul 29, 2018
@sbatten sbatten modified the milestones: July 2018, August 2018 Jul 29, 2018
@LordHog
Copy link
Author

LordHog commented Jul 30, 2018

@sbatten

Here is the output from screenfetch

                   ..                    
                 .PLTJ.                  OS: CentOS 
                <><><><>                 Kernel: x86_64 Linux 4.13.4-1.micronva.el7.centos.x86_64
       KKSSV' 4KKK LJ KKKL.'VSSKK        Uptime: 4d 19h 48m
       KKV' 4KKKKK LJ KKKKAL 'VKK        Packages: 1063
       V' ' 'VKKKK LJ KKKKV' ' 'V        Shell: bash 4.2.46
       .4MA.' 'VKK LJ KKV' '.4Mb.        Resolution: 1920x1080
     . KKKKKA.' 'V LJ V' '.4KKKKK .      DE: Xfce4
   .4D KKKKKKKA.'' LJ ''.4KKKKKKK FA.    WM: Xfwm4
  <QDD ++++++++++++  ++++++++++++ GFD>   WM Theme: Default
   'VD KKKKKKKK'.. LJ ..'KKKKKKKK FV     GTK Theme: Adwaita [GTK2]
     ' VKKKKK'. .4 LJ K. .'KKKKKV '      Icon Theme: gnome
        'VK'. .4KK LJ KKA. .'KV'         Font: Sans 10
       A. . .4KKKK LJ KKKKA. . .4        CPU: Intel Core i7-7700 @ 8x 4.2GHz [39.0°C]
       KKA. 'KKKKK LJ KKKKK' .4KK        GPU: Mesa DRI Intel(R) Kabylake GT2 
       KKSSA. VKKK LJ KKKV .4SSKK        RAM: 3188MiB / 15907MiB
                <><><><>                
                 'MKKM'                 
                   ''   

The Window Manager running, via xrdp, is XFCE

If I can think of anything else to add I will add them or please let me know what else you require.

Regards,
Mark

Edit: Here is some addition details from /etc/*-release

CentOS Linux release 7.3.1611 (Core) 
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"

CentOS Linux release 7.3.1611 (Core) 

@LordHog
Copy link
Author

LordHog commented Aug 13, 2018

@sbatten, I see this is still present on 1.26. Should I remove VSC and re-install everything?

@sbatten
Copy link
Member

sbatten commented Aug 14, 2018

@LordHog I have not yet diagnosed this issue, but this milestone I will be focusing on the mnemonics system in the custom menubar and will address this as well. Would you be able to check the dev tools to determine the fonts being loaded in the menus? If so, the trick to keeping the menus open in dev tools is opening the menu, then pausing the debugger. Thanks

@LordHog
Copy link
Author

LordHog commented Aug 15, 2018

@sbatten okay, I may need a bit more hand holding. I did find the developer tools in the Help Menu and sort of stumbled to find the dev tools highlight sections in the dev tools pane, but I can't figure out how to influence the dev tools to show me the info for the submenu under the main menu items.

image

@LordHog
Copy link
Author

LordHog commented Aug 15, 2018

Ok, I found the div class for the menu items, but nothing I don't see anything about a font

<div class="menubar-menu-items-holder monaco-menu-container" role="presentation" style="top: 30px; left: 250.262px;">
  <div class="monaco-menu" role="presentation">
    <div class="monaco-action-bar animated vertical" tabindex="0">
      <ul class="actions-container" role="menu">
        <li class="action-item" role="presentation">
          <a class="action-menu-item" role="menuitem" accesskey="s" tabindex="0">
            <span class="action-label" aria-label="Start Debugging">S̲tart Debugging</span>
            <span class="keybinding">F5</span>
          </a>
        </li>
        <li class="action-item" role="presentation">
          <a class="action-menu-item" role="menuitem" accesskey="w" tabindex="0">
            <span class="action-label" aria-label="Start Without Debugging">Start W̲ithout Debugging</span>
            <span class="keybinding">Ctrl+F5</span>
          </a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-menu-item disabled" role="menuitem" accesskey="s">
            <span class="action-label" aria-label="Stop Debugging">S̲top Debugging</span>
            <span class="keybinding">Shift+F5</span>
          </a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-menu-item disabled" role="menuitem" accesskey="r">
            <span class="action-label" aria-label="Restart Debugging">R̲estart Debugging</span>
            <span class="keybinding">Ctrl+Shift+F5</span>
          </a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-label icon separator disabled" role="presentation"></a>
        </li>
        <li class="action-item" role="presentation">
          <a class="action-menu-item" role="menuitem" accesskey="c" tabindex="0">
            <span class="action-label" aria-label="Open Configurations">Open C̲onfigurations</span>
          </a>
        </li>
        <li class="action-item" role="presentation">
          <a class="action-menu-item" role="menuitem" tabindex="0">
            <span class="action-label" aria-label="Add Configuration...">Add Configuration...</span>
          </a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-label icon separator disabled" role="presentation"></a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-menu-item disabled" role="menuitem" accesskey="o">
            <span class="action-label" aria-label="Step Over">Step O̲ver</span>
            <span class="keybinding">F10</span>
          </a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-menu-item disabled" role="menuitem" accesskey="i">
            <span class="action-label" aria-label="Step Into">Step I̲nto</span>
            <span class="keybinding">F11</span>
          </a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-menu-item disabled" role="menuitem" accesskey="u">
            <span class="action-label" aria-label="Step Out">Step Ou̲t</span>
            <span class="keybinding">Shift+F11</span>
          </a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-menu-item disabled" role="menuitem" accesskey="c">
            <span class="action-label" aria-label="Continue">C̲ontinue</span>
            <span class="keybinding">F5</span>
          </a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-label icon separator disabled" role="presentation"></a>
        </li>
        <li class="action-item" role="presentation">
          <a class="action-menu-item" role="menuitem" accesskey="b" tabindex="0">
            <span class="action-label" aria-label="Toggle Breakpoint">Toggle B̲reakpoint</span>
            <span class="keybinding">F9</span>
          </a>
        </li>
        <li class="action-item" role="presentation">
          <a class="action-menu-item monaco-submenu-item" role="menuitem" accesskey="n" tabindex="0" aria-haspopup="true">
            <span class="action-label" aria-label="New Breakpoint">N̲ew Breakpoint</span>
            <span class="submenu-indicator">â–¶</span>
          </a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-label icon separator disabled" role="presentation"></a>
        </li>
        <li class="action-item" role="presentation">
          <a class="action-menu-item" role="menuitem" tabindex="0">
            <span class="action-label" aria-label="Enable All Breakpoints">Enable All Breakpoints</span>
          </a>
        </li>
        <li class="action-item" role="presentation">
          <a class="action-menu-item" role="menuitem" accesskey="l" tabindex="0">
            <span class="action-label" aria-label="Disable All Breakpoints">Disable Al̲l Breakpoints</span>
          </a>
        </li>
        <li class="action-item" role="presentation">
          <a class="action-menu-item" role="menuitem" accesskey="a" tabindex="0">
            <span class="action-label" aria-label="Remove All Breakpoints">Remove A̲ll Breakpoints</span>
          </a>
        </li>
        <li class="action-item disabled" role="presentation">
          <a class="action-label icon separator disabled" role="presentation"></a>
        </li>
        <li class="action-item" role="presentation">
          <a class="action-menu-item" role="menuitem" accesskey="i" tabindex="0">
            <span class="action-label" aria-label="Install Additional Debuggers...">I̲nstall Additional Debuggers...</span>
          </a>
        </li>
      </ul>
    </div>
  </div>
</div>

@LordHog
Copy link
Author

LordHog commented Aug 15, 2018

@sbatten sorry, I am sort of all over the place as I experiment. I think the font being used is Segoe based upon this screen shot

image

@sbatten sbatten removed the info-needed Issue requires more information from poster label Aug 27, 2018
@jrieken jrieken added the verified Verification succeeded label Aug 30, 2018
@LordHog
Copy link
Author

LordHog commented Sep 5, 2018

@sbatten I just downloaded and installed VSC 1.27 and the menus are back to normal now. No more underscores. I had notice when clicking on a menu item the drop down window would be very slow or wouldn't show up, unless I clicked multiple times, but the menus seem a bit more responsive. Still a little slow, but much better than before. Thanks to the team for fixing this.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants