Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus: Consider using a stronger font-weight for UI #53076

Closed
octref opened this issue Jun 27, 2018 · 6 comments
Closed

Menus: Consider using a stronger font-weight for UI #53076

octref opened this issue Jun 27, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues

Comments

@octref
Copy link
Contributor

octref commented Jun 27, 2018

Refs: #52854

@bpasero @Tyriar @misolori Wondering what's your opinion? During today's testing I was staring at the menu for a few hours and I found the font too thin and lightweight.

I find increasing the font-weight to 500 makes it much easier to read.

For the sake of consistency, this will impact both Menu bar and the Panel Bar.

White

font-weight: 400

image

font-weight: 500

image

Dark

font-weight: 400

image

font-weight: 500

image

@octref octref added bug Issue identified by VS Code Team member as probable bug workbench-menu labels Jun 27, 2018
@octref
Copy link
Contributor Author

octref commented Jun 27, 2018

This is the effect of both fix #53007 (make label / shortcut both 12px, currently label is 11px and shortcut 12px) and applying the 500 font-weight:

image

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2018

I think we should try align with what Windows does by default

@bpasero
Copy link
Member

bpasero commented Jun 27, 2018

Yeah I find the menu in light theme especially hard to read. Agree, we should try to use a similar font size and weight as the default menus.

@miguelsolorio
Copy link
Contributor

I also agree that matching what Windows does by default. Is there a reason why we decided to not use the default font size/weight?

@sbatten sbatten added the debt Code quality issues label Jul 3, 2018
@Cirieno
Copy link

Cirieno commented Jul 6, 2018

Agreed. Having the items in a menu at a font smaller than the menu itself makes the menu items harder to read (thinking of anti-aliased / Cleartyped but not hi-def screens)

vscode_issues

Same issue: ref #52484

@sbatten
Copy link
Member

sbatten commented Jul 23, 2018

font sizing was changed via #54695, I think this solves the issue at heart here and font weight can remain the same. please re-open and provide feedback if you feel the weight is still an issue.

@sbatten sbatten closed this as completed Jul 23, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues
Projects
None yet
Development

No branches or pull requests

6 participants