Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] JSON array suggestion should stay single line #50528

Closed
fxedel opened this issue May 27, 2018 · 1 comment
Closed

[json] JSON array suggestion should stay single line #50528

fxedel opened this issue May 27, 2018 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality json JSON support issues
Milestone

Comments

@fxedel
Copy link

fxedel commented May 27, 2018

Issue Type: Feature Request

When you edit a JSON document with a JSON schema attached and accept a suggestion for a property that takes an array, the array is immediately enlarged into three lines.

But often, you don't want the array to take a line per array item, because the whole array could be written into a single line. You have to delete the automatically added lines by hand then. This is much more work than it would to take to press Enter if VSCode created inline arrays.

output

So my suggestion is not to create these extra lines and let the user decide whether he wants each item in a single line (press Enter) or the whole array in a single line.

VS Code version: Code 1.23.0 (7c7da59, 2018-05-03T15:23:19.356Z)
OS version: Linux x64 4.15.0-23-generic

@vscodebot vscodebot bot added editor editor-core Editor basic functionality labels May 27, 2018
@aeschli aeschli changed the title Prevent JSON array suggestion from creating new lines [json] JSON array suggestion should stay singe line May 28, 2018
@aeschli aeschli added this to the Backlog milestone May 28, 2018
@aeschli aeschli added feature-request Request for new features or functionality json JSON support issues and removed editor editor-core Editor basic functionality labels May 28, 2018
@felixfbecker
Copy link
Contributor

Agreed - same with objects actually. It's way easier to press return another time than to backspace it back on one line.

@fxedel fxedel changed the title [json] JSON array suggestion should stay singe line [json] JSON array suggestion should stay single line Jul 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality json JSON support issues
Projects
None yet
Development

No branches or pull requests

4 participants