Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If we need vscode-resource schema then localResourceRoots should use that schema as well. #48515

Closed
dbaeumer opened this issue Apr 24, 2018 · 1 comment
Closed

If we need vscode-resource schema then localResourceRoots should use that schema as well. #48515

dbaeumer opened this issue Apr 24, 2018 · 1 comment
Assignees
@mjbvz
Labels
*as-designed Described behavior is as designed

Comments

@dbaeumer
Copy link
Member

Tests #48453

Using different schema for basically the same think seems confusing to me. We should either use file for both or vscode-resource for both.
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 24, 2018

The current pattern makes sense if you think of localResourceRoots as saying, "here are the local resources I want a webview to be able to access through vscode-resource:". Having to use vscode-resource for localResourceRoots would also create unnecessary work for extension authors

@mjbvz mjbvz closed this as completed Apr 24, 2018
@mjbvz mjbvz added the *as-designed Described behavior is as designed label Apr 24, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*as-designed Described behavior is as designed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbaeumer @mjbvz