Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent deprecation of ViewColumn #48506

Closed
dbaeumer opened this issue Apr 24, 2018 · 1 comment
Closed

Inconsistent deprecation of ViewColumn #48506

dbaeumer opened this issue Apr 24, 2018 · 1 comment
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@dbaeumer
Copy link
Member

Tests #48453

readonly viewColumn?: ViewColumn; is deprecated but reveal(viewColumn?: ViewColumn): void; not. This seems to be inconsistent.

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 24, 2018

The intent is that viewColumn will be replaced by gridPosition or similar. When this happens, viewColumn will be undefined if the webview is not in any of the main columns, making the properly far less useful. We will always have a reveal method though, it will just would be overloaded to take a gridPosition instead of a viewColumn. Callingreveal using a viewColumn will continue to work in grid layout

@mjbvz mjbvz closed this as completed Apr 24, 2018
@mjbvz mjbvz added the *as-designed Described behavior is as designed label Apr 24, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

2 participants