Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the _GTK_THEME_VARIANT X11 property on top-level window to use "dark" theme on Gnome #45968

Closed
jeremy447 opened this issue Mar 16, 2018 · 2 comments
Closed

Set the _GTK_THEME_VARIANT X11 property on top-level window to use "dark" theme on Gnome #45968

jeremy447 opened this issue Mar 16, 2018 · 2 comments
Assignees
@bpasero
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@jeremy447
Copy link

Hello,

On Gnome with the default theme Adwaita, the titlebar is very bright an hurt your eyes. Adwaita have a dark variant and for Vs Code to use it, it just need to set the _GTK_THEME_VARIANT X11 property on top-level window to use "dark" theme.

27779206-bbb46458-5fc1-11e7-987c-57260b02ed8f
27779210-c1da4e10-5fc1-11e7-8cd1-f0161d14d16c

Can it be added please ? It's a very little modification but with great impact on usability on Gnome.

Thanks !

https://gitlab.gnome.org/GNOME/gtk/issues/99
@vscodebot
Copy link

vscodebot bot commented Mar 16, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bpasero
Copy link
Member

bpasero commented Mar 16, 2018

Merging into #16363

With Electron 2.x we can play around with adding a setting for this, since that comes with GTK3 support.

@bpasero bpasero closed this as completed Mar 16, 2018
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 16, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpasero @jeremy447