Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] proposals include true and false for boolean type regardless of enum #45821

Closed
castwide opened this issue Mar 15, 2018 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues verified Verification succeeded
Milestone

Comments

@castwide
Copy link

This issue was discovered in rubyide/vscode-ruby#295.

Add a configuration contribution to an extension's package.json that accepts both boolean and string types, but give it an enum that doesn't include one of the boolean options:

"ruby.codeCompletion": {
  "type": ["boolean", "string"],
  "enum": [false, "rcodetools"],
  "default": false,
  "description": "Method to use for code completion. Use `false` if another extension provides this feature."
}

When editing the configuration in User Settings, the completion items include true despite the enum:

image

@sandy081
Copy link
Member

@aeschli I think it is related to JSON

@aeschli aeschli added json JSON support issues bug Issue identified by VS Code Team member as probable bug labels Mar 15, 2018
@aeschli aeschli added this to the Backlog milestone Mar 15, 2018
@aeschli aeschli changed the title Completion items for settings.json always include true and false for boolean type regardless of enum [json] proposals include true and false for boolean type regardless of enum Mar 15, 2018
@aeschli aeschli modified the milestones: Backlog, March 2018 Mar 26, 2018
@tsalinger tsalinger added the verified Verification succeeded label Mar 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants