Don't show hint diagnostics in problems view?

[mjbvz]

Problem
TypeScript is introducing new "suggest" diagnostics (#45378 + #45433) that seem to map to our DiagnosticServerity.Hint level. Example suggest diagnostic: convert a es5 class to an es6 class.

However these hint diagnostics still are still show in the problems view, which adds a lot of noise

Proposal
Don't show hint diagnostics in the problems panel. They are already not shown in the editor. Not sure if any extensions depend on the current functionality

[mjbvz]

If we are concerned about regressing extensions, two other options:

• Introduce a new, even lower severity diagnostic level that never shows in the UI

• Allow diagnostics or diagnostics collection themselves to say if they show in the UI or not

[sandy081]

@jrieken Since, we are planning to move F8 functionality being driven from editor to problems view, does it mean that F8 now will also navigate through all types of diagnostics?

How about adding a setting to exclude diagnostics by type which can be language overridden?

[jrieken]

We should always ignore Hint (the editor already does that today), the F8 likely doesn't... We should add something to IMarkerService#read so that it filters on severities

[mjbvz]

We can discuss this at the UX sync but I think a good experience would be:

• By default, TS suggestion diagnostics such as convert a es5 class to an es6 class show as faint gray underlines in the editor. This would let users know where they can perform code actions. These diagnostics would not show in the problems view or participate in F8

• We provide an option this hide these suggestion diagnostics in the editor as well. TS is looking into per-error suppressions but I think we need global solution on the VS Code side as well

Not sure how these would map to our diagnostic api

[jrieken]

This is somewhat the same as #44141

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!