Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the possibility of committing "a line break as a message" to git #45031

Closed
ghost opened this issue Mar 5, 2018 · 3 comments · Fixed by #45254
Closed

Prevent the possibility of committing "a line break as a message" to git #45031

ghost opened this issue Mar 5, 2018 · 3 comments · Fixed by #45254
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Milestone

Comments

@ghost
Copy link

ghost commented Mar 5, 2018

you can commit "a line break as a message" to git

@vscodebot
Copy link

vscodebot bot commented Mar 5, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the git GIT issues label Mar 5, 2018
@ghost ghost changed the title you can commit with a line break to git you can commit "a line break as a message" to git Mar 5, 2018
@joaomoreno joaomoreno changed the title you can commit "a line break as a message" to git Prevent the possibility of committing "a line break as a message" to git Mar 5, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Mar 5, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Mar 5, 2018
@gnijuohz
Copy link
Contributor

gnijuohz commented Mar 6, 2018

Hi @joaomoreno I would like to take up this task. Could you point me to a starting point?

@joaomoreno
Copy link
Member

joaomoreno commented Mar 6, 2018

@gnijuohz We don't really have to prevent it, but we can warn the user about it. Over here there is some validation of the input box happening (for when lines are too long, for example). Maybe we can also warn the user that the current input isn't valid when all he does is enter a bunch of line breaks in it. But there should be no warning for when the box is empty, otherwise it would be too much "in the user's face".

@joaomoreno joaomoreno modified the milestones: Backlog, June 2018 Jun 4, 2018
@mjbvz mjbvz added the verified Verification succeeded label Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants