Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix for installing @type removes installed modules #42535

Closed
octref opened this issue Jan 30, 2018 · 2 comments
Closed

Quickfix for installing @type removes installed modules #42535

octref opened this issue Jan 30, 2018 · 2 comments
Assignees
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@octref
Copy link
Contributor

octref commented Jan 30, 2018

Testing #42358

  1. Have a workspace that already installs request and lodash
  2. Have a file like so
import * as _ from 'lodash'
import * as req from 'request'
  1. Quick fix anyone of them by installing @types dependency
  2. Notice many installed modules in your node_modules are gone

Before:

image

After:

image

@octref octref added the typescript Typescript support issues label Jan 30, 2018
@octref
Copy link
Contributor Author

octref commented Jan 30, 2018

This happens when you have a node_modules installed using yarn (if using npm it seems work fine).

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 31, 2018

Thanks! Opened microsoft/TypeScript#21504 to track this upstream

@mjbvz mjbvz closed this as completed Jan 31, 2018
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jan 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants