Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always log extension host init data #39805

Closed
jrieken opened this issue Dec 6, 2017 · 1 comment
Closed

Don't always log extension host init data #39805

jrieken opened this issue Dec 6, 2017 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug perf-startup verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Dec 6, 2017

re #39572

The extension host init data is a monster, depending on your configuration and installed extensions easily 1MB. We always log this (level=info) and to make matter worse we serialise it again... So instead of taking the monster string we have send over, we take the just parsed object and create yet another monster string... Two things I'd do different: don't use log level info, log the extension IPC which is already strings

@joaomoreno
Copy link
Member

We don't have a log service that early in the game, so I'll move the init data logging to a trace level.

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Dec 6, 2017
@joaomoreno joaomoreno added this to the November 2017 milestone Dec 6, 2017
@bpasero bpasero added the verified Verification succeeded label Dec 7, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug perf-startup verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants