Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code should validate relative path in workspace file and behave more gracefully #33404

Closed
dbaeumer opened this issue Aug 29, 2017 · 3 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@dbaeumer
Copy link
Member

Testing: #33278

  • create a workspace file with only relative paths
  • copy the file using OS means (file explorer) where the folder don't make any sense
  • open the file

Observe:

  • you see the folder structure also not existing on disk
  • clicking on a folder shows an error message:

capture

I would have expected that the folders are rendered gray / disabled and that clicking on them shows me a better error message

@dbaeumer
Copy link
Member Author

I would also expect that Remove Folder is available in the context menu

capture

@bpasero bpasero modified the milestone: August 2017 Aug 30, 2017
@bpasero bpasero added the workbench-multiroot Multi-root (multiple folders) issues label Aug 30, 2017
@bpasero
Copy link
Member

bpasero commented Aug 30, 2017

This basically is #29738

We should still show the root folder without error and allow to remove it. But it should be clear that the folder cannot be found (e.g. greyed out or with different icon). Also, file actions need to be restricted for that case.

@bpasero bpasero assigned isidorn and unassigned bpasero Aug 30, 2017
@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2017

Dup of #29738

@isidorn isidorn closed this as completed Aug 30, 2017
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

3 participants