Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no shortcut to open the integrated terminal on Linux #32473

Closed
jeremy447 opened this issue Aug 14, 2017 · 19 comments
Closed

There is no shortcut to open the integrated terminal on Linux #32473

jeremy447 opened this issue Aug 14, 2017 · 19 comments
Assignees
Labels
info-needed Issue requires more information from poster keybindings VS Code keybinding issues *question Issue represents a question, should be posted to StackOverflow (VS Code) terminal General terminal issues that don't fall under another label

Comments

@jeremy447
Copy link

Hello,

There is no shortcut to open the integrated terminal on Linux.

  • VSCode Version: 1.15
  • OS Version: Ubuntu
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Aug 14, 2017
@Tyriar
Copy link
Member

Tyriar commented Aug 14, 2017

ctrl+` opens the integrated terminal on Ubuntu. You can customize this using the keybindings system https://code.visualstudio.com/docs/getstarted/keybindings

@Tyriar Tyriar closed this as completed Aug 14, 2017
@jeremy447
Copy link
Author

I'm sorry I should have been more precise. I know that there should be that shortcut ctrl+` to open integrated terminal on Ubuntu but I tried it and it doesn't work (tried ctrl+² too for my locale (fr) ). I looked for it in the keyboard shortcuts and keybindings and it doesn't exist !

@Tyriar
Copy link
Member

Tyriar commented Aug 14, 2017

@Paviluf what shows up when you search for "Toggle Terminal" in keybindings?

image

@Tyriar Tyriar reopened this Aug 14, 2017
@Tyriar Tyriar added the info-needed Issue requires more information from poster label Aug 14, 2017
@jeremy447
Copy link
Author

Here it is on Fedora (at home, the ubuntu one is at work)

screenshot from 2017-08-14 22-56-31

@Tyriar
Copy link
Member

Tyriar commented Aug 14, 2017

Looks like there is not shortcut by default for your locale, you can add one by hovering the row and hitting the pencil button on the left.

@jeremy447
Copy link
Author

Thanks that work. Shouldn't it be working out of the box, even with french locale ?

@Tyriar
Copy link
Member

Tyriar commented Aug 18, 2017

Seems to work fine on Ubuntu, at least when I launch using code --locale=fr:

image

Let me know if your work Ubuntu machine is fine.

@jeremy447
Copy link
Author

The shortcut isn't present even with --locale=fr on my Ubuntu computer.

@Tyriar
Copy link
Member

Tyriar commented Aug 18, 2017

Weird.. I assume you have fr set up as the system language? Maybe that's the issue. Moving to @alexandrudima as it seems to relate to the keybindings system.

@Tyriar Tyriar assigned alexdima and unassigned Tyriar Aug 18, 2017
@Tyriar Tyriar added the keybindings VS Code keybinding issues label Aug 18, 2017
@jeremy447
Copy link
Author

Well on Fedora the "language" is set to english but the "formats" to french. However on Ubuntu it's full french.

@alexdima
Copy link
Member

Our out-of-the-box keybinding for toggle terminal is ctrl + ` , which is interpreted as ctrl + the key combination that produces `. If for your keyboard layout no key combination produces `, then the toggle terminal command is unbound by default.

Simply click on the edit pencil next to the command and bind it to a keybinding.

@alexdima alexdima added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Sep 28, 2017
@jeremy447
Copy link
Author

You should reopen because there is a ` on my keyboard.

@alexdima alexdima reopened this Sep 29, 2017
@alexdima
Copy link
Member

@Paviluf ok. Can you then please do the following:

  • open an editor
  • run F1 > Developer: Inspect key mappings
  • save as a file and upload here

I can then take a look and see if our logic is flawed.

@jeremy447
Copy link
Author

jeremy447 commented Sep 29, 2017

Here it is from my Chromebook (the ` is on letter 7).

keyboard.txt

image

@alexdima
Copy link
Member

alexdima commented Sep 29, 2017

@Paviluf

|       HW Code combination      |  Key  |
|                Ctrl+Alt+Digit7 |   `   |
"Digit7": {
	"value": "è",
	"withShift": "7",
	"withAltGr": "`",
	"withShiftAltGr": "⅞"
},

Indeed, ` can be produced by pressing AltGr + [Digit7]. i.e. ctrl+alt+[Digit7]. The relevant rows are above.

This means that our out of the box keybinding for ctrl+` would map to ctrl+ctrl+alt+[Digit7]. Since this is not expressible in terms of modifiers (it would require some form of modifier chording which AFAIK no editor supports), the keybinding for toggle integrated terminal is not bound out of the box.

Does that make sense?

@jeremy447
Copy link
Author

That make sense. Just note that only AltGr + [Digit7] produce ` not ctrl+alt+[Digit7].

@alexdima
Copy link
Member

alexdima commented Sep 29, 2017

AltGr is Ctrl+Alt
AltGr+[Digit7] is Ctrl+Alt+[Digit7].

This is explained in https://en.wikipedia.org/wiki/AltGr_key#Control_.2B_Alt_as_a_substitute

In effect, we cannot differentiate AltGr from Ctrl+Alt+.

@alexdima
Copy link
Member

Since I believe our algorithm for mapping default keybindings to the current keyboard layout is correct, I will close this issue for now.

Please upvote #1240 which is about that we ship with keyboard layout optimized default keybindings.

@jeremy447
Copy link
Author

AltGr+[Digit7] is Ctrl+Alt+[Digit7]

Maybe but if I press it, nothing happen.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster keybindings VS Code keybinding issues *question Issue represents a question, should be posted to StackOverflow (VS Code) terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

4 participants