Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot select link in terminal #25155

Closed
chrmarti opened this issue Apr 21, 2017 · 4 comments
Closed

Cannot select link in terminal #25155

chrmarti opened this issue Apr 21, 2017 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
June 2017

Comments

@chrmarti
Copy link
Collaborator

  • VSCode Version: Code - Insiders 1.12.0-insider (6c59263, 2017-04-21T06:05:34.726Z)
  • OS Version: Darwin x64 15.6.0
  • Extensions: None

Steps to Reproduce:

  1. Select the text of a link in the terminal.
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Apr 21, 2017
@Tyriar
Copy link
Member

Tyriar commented Apr 24, 2017 •
edited
Loading

I remember seeing this when I was adding the feature. It's related to using the <a> which appeared to have limitations on selecting. You can select it but not when double clicking.

This will be fixed as part of #9958 (added it to the list)

@Tyriar Tyriar closed this as completed Apr 24, 2017
@Tyriar Tyriar mentioned this issue Apr 24, 2017
Closed
@Tyriar Tyriar added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels Apr 24, 2017
@Tyriar Tyriar mentioned this issue Jun 8, 2017
Closed
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed *duplicate Issue identified as a duplicate of another issue(s) labels Jun 9, 2017
@Tyriar Tyriar added this to the June 2017 milestone Jun 9, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 9, 2017

Fixed in #9958, xtermjs/xterm.js#670

@roblourens
Copy link
Member

I can't repro in stable?

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2017

@roblourens the underlying problem is that you can't select an <a> tag. Make sure that's what is what you're trying to select i the DOM.

@bpasero bpasero added the verified Verification succeeded label Jun 30, 2017
@Tyriar Tyriar mentioned this issue Jul 4, 2017
Merged
64 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
4 participants
@roblourens @bpasero @Tyriar @chrmarti