Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salsa does not flag ReferenceErrors in strict mode #2450

Closed
alexdima opened this issue Jan 27, 2016 · 1 comment
Closed

Salsa does not flag ReferenceErrors in strict mode #2450

alexdima opened this issue Jan 27, 2016 · 1 comment
Assignees

Comments

@alexdima
Copy link
Member

Testing #2218

From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode

"use strict";
                       // Assuming a global variable mistypedVariable exists
mistypedVaraible = 17; // this line throws a ReferenceError due to the 
                       // misspelling of variable

When I run it with node v0.12.7 I do get a ReferenceError:

c:\Alex\working_dir\salsa\strict.js:3
mistypedVaraible = 17; // this line throws a ReferenceError due to the
                 ^
ReferenceError: mistypedVaraible is not defined
    at Object.<anonymous> (c:\Alex\working_dir\salsa\strict.js:3:18)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3

I expect Salsa to flag as much as possible of runtime errors, including strict mode reference errors

@egamma
Copy link
Member

egamma commented Jan 27, 2016

This issue was moved to microsoft/TypeScript#6652

@egamma egamma closed this as completed Jan 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants