Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delayed app-ready event #22087

Closed
jrieken opened this issue Mar 6, 2017 · 18 comments
Closed

delayed app-ready event #22087

jrieken opened this issue Mar 6, 2017 · 18 comments
Assignees
Labels
electron Issues and items related to Electron perf perf-startup upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream windows VS Code on Windows issues

Comments

@jrieken
Copy link
Member

jrieken commented Mar 6, 2017

We see traces in which Electron takes a very long time to to receive the app-ready event. Because we cannot do anything useful before that happens it blocks startup badly. AV software is suspected to be causing this.

@jrieken jrieken added perf upstream Issue identified as 'upstream' component related (exists outside of VS Code) bug Issue identified by VS Code Team member as probable bug labels Mar 6, 2017
@jrieken
Copy link
Member Author

jrieken commented Mar 6, 2017

The issue for electron is electron/electron#1487

This was referenced Mar 6, 2017
@ramya-rao-a
Copy link
Contributor

The upstream issue was closed saying that there is nothing they can do electron/electron#1487 (comment)

So what are we expecting here?

@jrieken
Copy link
Member Author

jrieken commented Mar 6, 2017

I wanted something in our repo to point to... This comes up frequently and should be the central point for information around this.

@devils2ndself
Copy link

so I've been having having this issue with delayed appready event (it has been taking around 16-17 seconds as the startup performance was saying) for quite some time and I've been struggling with finding a correct solution (it didn't even go away after I uninstalled every bit of AV software on my laptop). but thank god, eventually I found what the problem was. apparently, if you have a somewhat recently released laptop, it will most probably have "nahimic" audio drivers. I actually haven't found a way to uninstall it (maybe installing a different audio driver will do but I haven't tried yet) but ending the "nahimicService" task in the task manager solves the problem for me.

@douglasparker
Copy link

so I've been having having this issue with delayed appready event (it has been taking around 16-17 seconds as the startup performance was saying) for quite some time and I've been struggling with finding a correct solution (it didn't even go away after I uninstalled every bit of AV software on my laptop). but thank god, eventually I found what the problem was. apparently, if you have a somewhat recently released laptop, it will most probably have "nahimic" audio drivers. I actually haven't found a way to uninstall it (maybe installing a different audio driver will do but I haven't tried yet) but ending the "nahimicService" task in the task manager solves the problem for me.

Thanks for sharing this information. I've been really struggling with this too. It's a huge pain because I use VSCode as my default editor for everything and the delayed startup is horrible even on my high end workstation.

Nahimic is the confirmed culprit for me.

@loopervfx
Copy link

loopervfx commented Jul 13, 2021

I also have this issue. i was led here from #127909. Nahimic Service is enabled by default on many Asus computers, and other makes. Disabling a service manually is not really an acceptable solution and in my case it gets reenabled regularly by system updates. And it can't be uninstalled without also removing your onboard audio drivers. (manually extracting installing .inf drivers to work around this isn't a real solution either as aside from being super hacky and disables many features, it's impossible to unpack the inf files from many installers these days.) Very strange that it would cause this kind of interference though Nahimic Service is known to cause issues with other applications, e.g. it can cause SideFX Houdini to crash at random.

Even if there is nothing that can be done to eliminate this issue directly from the VScode developers or indirectly the Electron developers (I have no idea if where the onus lies), it should be clearly documented as a possible issue (as it is in SideFX Houdini troubleshooting docs) and perhaps even a warning issued in vscode if the Nahimic Service is detected since it is so detrimental, it makes vscode nearly unusable as there is a 10 second delay with EVERY file opened, it's not just a delay of initial app startup which is bad enough.

Very likely that this often goes unreported as it doesn't completely block VScode from working, it just gives the (very false) impression that VScode and/or the user's computer is a stinking hot unoptimized piece of garbage. So it's work looking into to try and remedy that false perception alone on every single Asus computer in existence and any others that have Nahimic bundle with their audio drivers. Again i'm not blaming VScode for this, it's more likely something nasty that Nahimic is doing but it is also puzzling why certain applications like VScode are somehow severely affected and interfered with while most others are not.

Cheers

@douglasparker
Copy link

This issue just keeps being swept under the rug. I stopped even trying to get them to address it because they'll just close and lock issues.

@loopervfx
Copy link

loopervfx commented Jul 13, 2021

This issue just keeps being swept under the rug. I stopped even trying to get them to address it because they'll just close and lock issues.

This is the master issue, and is "Open," it's the duplicate issues that are getting closed and locked. And as mentioned in earlier comments here, it is apparently some conflict between Electron and Nahimic (and various Anti Virus softwares,) the VScode devs can't resolve it directly even if they wanted to.

@douglasparker
Copy link

douglasparker commented Jul 14, 2021

This issue just keeps being swept under the rug. I stopped even trying to get them to address it because they'll just close and lock issues.

This is the master issue, and is "Open," it's the duplicate issues that are getting closed and locked. And it is apparently some problem between Electron and Nahimic, the VScode devs can't resolve it directly even if they wanted to.

Ah, I see. It might be better if someone raises this issue with the Electron team then. I'm surprised nobody from the VS Code team mentioned this sooner. Anyways, thanks for the useful information.

Edit: The original issue should probably be updated with the relevant information in regards to the nahimic service conflicting with electron.

I didn't think my issues should have been closed because this issue here is addressing a delayed app-ready event caused by AV, not the nahimic service.

@deepak1556
Copy link
Collaborator

Closing as the master issue isn't helpful, slow startup can vary depending on the users setup and I am triaging them on a case by case basis.

@deepak1556 deepak1556 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
@douglasparker
Copy link

Closing as the master issue isn't helpful, slow startup can vary depending on the users setup and I am triaging them on a case by case basis.

So you guys spend 5 years closing issues as duplicates and now you want us to create individual issues again? 😡

@deepak1556
Copy link
Collaborator

Issues that were merged to this one were not actionable ones that was resolved with changes to other third-party software, if you are still facing slow startup with latest versions of VSCode, please let me know and I can look into it.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron perf perf-startup upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

9 participants