We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
git init
before.js
git add .
after.js
Source Control
The highlighted code is incorrect as shown by the arrow in the screenshot.
Code:
class RenderTarget { constructor(options = {}) { this.texture = new Texture(image, options.mapping, options.wrapS, options.wrapT, options.magFilter, options.minFilter, options.format, options.type, options.anisotropy, options.colorSpace); this.texture.isRenderTargetTexture = true; this.texture.flipY = false; this.texture.generateMipmaps = options.generateMipmaps !== undefined ? options.generateMipmaps : false; this.texture.internalFormat = options.internalFormat !== undefined ? options.internalFormat : null; this.texture.minFilter = options.minFilter !== undefined ? options.minFilter : LinearFilter; this.depthBuffer = options.depthBuffer !== undefined ? options.depthBuffer : true; this.stencilBuffer = options.stencilBuffer !== undefined ? options.stencilBuffer : false; this.depthTexture = options.depthTexture !== undefined ? options.depthTexture : null; this.samples = options.samples !== undefined ? options.samples : 0; } }
class RenderTarget { constructor(options = {}) { const { generateMipmaps = false, internalFormat = null, minFilter = LinearFilter, depthBuffer = true, stencilBuffer = false, depthTexture = null, samples = 0 } = options; this.texture = new Texture(image, options.mapping, options.wrapS, options.wrapT, options.magFilter, options.minFilter, options.format, options.type, options.anisotropy, options.colorSpace); this.texture.isRenderTargetTexture = true; this.texture.flipY = false; this.texture.generateMipmaps = generateMipmaps; this.texture.internalFormat = internalFormat; this.texture.minFilter = minFilter; this.depthBuffer = depthBuffer; this.stencilBuffer = stencilBuffer; this.depthTexture = depthTexture; this.samples = samples; } }
--- a/test.js +++ b/test.js @@ -1,18 +1,28 @@ class RenderTarget { constructor(options = {}) { + const { + generateMipmaps = false, + internalFormat = null, + minFilter = LinearFilter, + depthBuffer = true, + stencilBuffer = false, + depthTexture = null, + samples = 0 + } = options; + this.texture = new Texture(image, options.mapping, options.wrapS, options.wrapT, options.magFilter, options.minFilter, options.format, options.type, options.anisotropy, options.colorSpace); this.texture.isRenderTargetTexture = true; this.texture.flipY = false; - this.texture.generateMipmaps = options.generateMipmaps !== undefined ? options.generateMipmaps : false; - this.texture.internalFormat = options.internalFormat !== undefined ? options.internalFormat : null; - this.texture.minFilter = options.minFilter !== undefined ? options.minFilter : LinearFilter; + this.texture.generateMipmaps = generateMipmaps; + this.texture.internalFormat = internalFormat; + this.texture.minFilter = minFilter; - this.depthBuffer = options.depthBuffer !== undefined ? options.depthBuffer : true; - this.stencilBuffer = options.stencilBuffer !== undefined ? options.stencilBuffer : false; + this.depthBuffer = depthBuffer; + this.stencilBuffer = stencilBuffer; - this.depthTexture = options.depthTexture !== undefined ? options.depthTexture : null; + this.depthTexture = depthTexture; - this.samples = options.samples !== undefined ? options.samples : 0; + this.samples = samples; } }
Screenshot:
Relatived PR: mrdoob/three.js#26775
The text was updated successfully, but these errors were encountered:
Technically, the diff is not incorrect, but I still believe there is a bug in the diff shifting logic.
This is the result from the myers diff algorithm:
Post processing yields this:
(Playground repro)
Sorry, something went wrong.
Related: #193342
hediet
No branches or pull requests
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
git init
before.js
git add .
after.js
Source Control
The highlighted code is incorrect as shown by the arrow in the screenshot.
Code:
before.js
after.js
Screenshot:
Relatived PR: mrdoob/three.js#26775
The text was updated successfully, but these errors were encountered: