Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Partial Profiles #188613

Closed
3 tasks done
sandy081 opened this issue Jul 23, 2023 · 4 comments
Closed
3 tasks done

Test Partial Profiles #188613

sandy081 opened this issue Jul 23, 2023 · 4 comments

Comments

@sandy081
Copy link
Member

sandy081 commented Jul 23, 2023

Refs: #156144

Complexity: 4

Create Issue


Introduction

You can now create a partial profile, ie., a profile in which you can customise only some configurations (Settings, Keyboard Shortcuts, User Snippets, User Tasks, Extensions). When such a profile is active, VS Code uses the customisations from default profile for those configurations which are not part of the profile. For example: You can have a Profile with all configurations except for Keyboard Shortcuts, and use Default Profile for it.

You can create such a profile using the new Create Profile flow (Settings Gear > Profile > Create Profile...) in which you can select what can be configured in the profile.

Testing

Creating

Test creating a partial profile with various options available in the create profile flow

  • Empty (Copy from None)
  • Copying from a template
  • Copying from existing profile

and make sure the partial profile is created and applied as expected. Please play around with this flow and provide feedback.

Editing

You can update these options after creating the profile using Settings Gear > Profile > Edit Profile... action. Try editing the profile and changing the options and test if the update is working as expected.

Other Features

  • Test exporting such a profile
  • Test such profiles are synced as expected across machines (You can use different user-data-dir and extensions-dir and launch VS Code for testing syncing)
@sandy081 sandy081 added this to the July 2023 milestone Jul 23, 2023
@tanishqmanuja
Copy link

Use case: #156144 (comment)

Is there a PR associated for partial profiles or will it be in Insiders for testing?

@sandy081
Copy link
Member Author

@tanishqmanuja This is the issue you might want to comment in - #188612

@aiday-mar
Copy link
Contributor

aiday-mar commented Jul 25, 2023

Hey @sandy081, I am testing the partial profiles. While testing, I had the following thoughts:

  1. I created an empty profile that only configures the settings and the keyboard shortcuts, meaning that the extensions were inherited from the default profile. Upon creation, I noticed that all my extensions were enabled, while in the default profile some were disabled. Do you think it would make sense to inherit also the disabled/enabled states from the default profile?
  2. When I clicked on Edit Profile..., I noticed that the checkboxes that are enabled are not always the same as the ones that were previously checked during profile creation. Here is a video showing what I mean:
Screen.Recording.2023-07-25.at.10.33.46.mov

I was wondering if this was intended? For my Test Python profile, on clicking Edit profile..., I expected to see only settings, user tasks and extensions checked.

  1. I am unsure if I am testing wrong, but I am having trouble syncing the profiles across different vscode instances in different user directories. Here is a video showing what I mean. Should I have seen the Test Angular profile appear in the second instance too?
Screen.Recording.2023-07-25.at.10.51.05.mov

@sandy081
Copy link
Member Author

@aiday-mar

Do you think it would make sense to inherit also the disabled/enabled states from the default profile?

Definitely makes sense. At present this is happening because of the implementation limitation: Extensions enablement state is stored in storage. Please file a feature request for this.

I was wondering if this was intended? For my Test Python profile, on clicking Edit profile..., I expected to see only settings, user tasks and extensions checked.

I do not think it is expected. Editing the profile should retain the configuration when it was created. Please file an issue with steps to reproduce.

I am unsure if I am testing wrong, but I am having trouble syncing the profiles across different vscode instances in different user directories. Here is a video showing what I mean. Should I have seen the Test Angular profile appear in the second instance too?

I see you have not enabled Settings Sync. You have to Turn on Settings Sync for the syncing of data to happen. Sorry that I did not mention that assuming it was obvious. I would also recommend to use different extensions directory for the second instance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants