inline suppress suggestions doesn't work anymore

[svipas]

Type: Bug

Seems like newest VS Code version (1.79.0) broke down "editor.inlineSuggest.suppressSuggestions": false. If I type . (dot) or text while inline suggestions are visible suggest widget doesn't show anymore, I need to trigger it manually. In previous version it showed even when inline suggestions were visible.

Screen.Recording.2023-06-22.at.10.00.46.AM.mov

Code snippet

class User {
  get userId() {
    return "userId"
  }
}

const user = new User()

user

VS Code version: Code 1.79.0 (b380da4, 2023-06-07T14:31:03.317Z)
OS version: Darwin arm64 22.5.0
Modes:

System Info

Item	Value
CPUs	Apple M1 Pro (10 x 24)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	2, 2, 3
Memory (System)	32.00GB (1.08GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (12)

Extension	Author (truncated)	Version
vscode-eslint	dba	2.4.0
gitlens	eam	13.6.0
prettier-vscode	esb	9.13.0
copilot	Git	1.88.132
vscode-graphql	Gra	0.8.13
vscode-graphql-syntax	Gra	1.2.0
symbols	mig	0.0.11
vscode-react-native	msj	1.11.0
vscode-thunder-client	ran	2.7.6
vscode-fileutils	sle	3.10.1
vim	vsc	1.25.2
quokka-vscode	Wal	1.0.543

(1 theme extensions excluded)

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.79.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[svipas]

Updated to latest version (1.79.2) + updated my extensions including GitHub Copilot and issue is still the same. What I see is that it works for first time, but if I hide suggest widget it doesn't show anymore, shouldn't it re-trigger it again?

Screen.Recording.2023-06-22.at.10.11.50.AM.mov

[isidorn]

@svipas thanks for opening this issue but the Copilot team is aware of this and @SmallLemur is driving this effort on the GitHub Copilot side. I expect this to be fixed soon-ish. Fabien has more details.

[svipas]

@isidorn Thanks for info 👍

[svipas]

Updated Copilot to v1.99.289 and VS Code to 1.80.1 issue is still the same, not sure if anybody tried to fix it, but thought I would write so we have a track of it.

[svipas]

@isidorn @hediet Is it really GitHub Copilot bug? There's a setting editor.inlineSuggest.suppressSuggestions coming from VS Code, I thought VS Code is responsible for showing and hiding inline suggestions, GitHub Copilot pushes available suggestions to the list so VS Code knows what to show, but GH Copilot doesn't control showing or hiding them, or I'm wrong? Because to me this looks like VS Code regression since previously it was working fine 🤔

[isidorn]

@svipas yes it is really a Copilot bug. Since an inlineCompletionProvide can control the behaviour and has priority over the suppressSuggestions setting.
@whatsinfinitum is driving a Copilot experiment that will tackle this.

[svipas]

@isidorn Didn't know that, thanks for info. I really like suppressSuggestions setting, previously it was kinda annoying how Copilot tried to predict everything and suggest widget was not showing up, so I'm really keen to have this functionality back. This setting with Copilot is match made in heaven 😃

[svipas]

@isidorn Time is passing and I don't see any changes from Copilot side.

Shouldn't VS Code have priority to control this behavior? So such extensions as Copilot wouldn't have any control other this, because I assume this could happen again, and also setting suppressSuggestions is coming from VS Code so it kinda makes sense that VS Code should be in full control. Because now even though setting exists in VS Code, extension controls behavior so that setting should be in extension not in VS Code (my opinion).

Sorry if this sounds like a push, I'm just actually curious why VS Code is not the one who controls it fully instead of giving control to extension which as we could see is not a good thing, because this problem exists and could be repeated again...

[isidorn]

Good points. I expect that we get this resolved in the next month or so.

[svipas]

Finally! Thanks @isidorn @hediet ❤️ Let me know when I need to verify it if necessary 🙂

[isidorn]

@svipas you can try it out with VS Code Insiders tomorrow and let us know what you think. Thank you!!

[Destroy666x]

This fix is released in recent August version, right? The insiders-released label is kind of confusing.

If so, it still doesn't seem to work for me @hediet @isidorn:



Changing the setting doesn't do anything. Changing inline to on brings the widget back.

Windows 10

[svipas]

@Destroy666x This is a different thing. It was when suggest widget is visible, what you're asking is impossible to achieve, because Copilot uses inline suggestions and Copilot has priority over VS Code inline suggestions. In order to them both work nicely you have to use "on" to show suggest widget and Copilot uses inline.

What you can also do is to disable Copilot and always manually invoke it with your keyboard shortcut.

insiders-released label means that it was released on the Insiders version and users are able to check it out there, but now it is available in both Insiders & regular.

[Destroy666x]

@svipas no clue what that means as I don't even have Copilot installed.

[svipas]

@Destroy666x Sorry, thought you have Copilot installed. When I'm not quite sure I understand what you meant by writing comment above. Because inline suppose to hide suggest widget and show only completions inline without showing suggest widget. With on it shows them only in suggest widget.

Suppress suggestions setting is mostly when you're using extension which provides inline completions and you want to control behavior when to show suggest widget, this issue was about suggest widget not visible when Copilot shows inline suggestions and now it is fixed and they both work seamlessly.

[Destroy666x]

I would simply like both the inline suggestion displayed with a widget to see all of them. Which is how certain shell Tab completion works.

The setting is very confusing in that case IMO, it doesn't mention extensions anywhere.

I guess I'll create a suggestion then.

[svipas]

@Destroy666x Maybe you're looking for this one: "editor.suggest.preview": true, add it into your settings and keep on for quick suggestions.

[Destroy666x]

@svipas thanks, that's the result I'm looking for.