Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open New External Terminal command opens an extra one too #183401

Closed
aderchox opened this issue May 25, 2023 · 3 comments
Closed

Open New External Terminal command opens an extra one too #183401

aderchox opened this issue May 25, 2023 · 3 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@aderchox
Copy link

aderchox commented May 25, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.78.2 (user setup)
  • OS Version: Windows 10 x64 10.0.19045.2965

Steps to Reproduce:

  1. Open VSCode
  2. Either trigger the command workbench.action.terminal.openNativeConsole, or use its hotkey Ctrl + Shift + C (in my case).
  3. Opens both the terminal I had last time restoring its layout (e.g., if it was vertically split, it's kept that layout) which is what I expect and is fine and very helpful indeed, however, opens up another (extra) bare instance of the terminal as well, which I don't want, and I always have to close it manually.
    Here's a GIF screenshot of the issue:
    extra-external-terminal
@meganrogge
Copy link
Contributor

Am I correct in understanding from your gif that the new terminal is opening in your external terminal window? If so, I don't believe we can impact how that program works.

@meganrogge meganrogge added the info-needed Issue requires more information from poster label May 25, 2023
@aderchox
Copy link
Author

aderchox commented May 25, 2023

Am I correct in understanding from your gif that the new terminal is opening in your external terminal window? If so, I don't believe we can impact how that program works.

Sorry your question is not quite clear to me. I'm running the command to open a new external terminal, so yes, the new terminal "is in an external terminal window", but the main issue isn't that. The main thing here is, I expect a single external terminal window to open, but it opens two windows instead (in the gif example, there's one that has no splits, and one that has splits in it. I only need the one with splits).

@meganrogge
Copy link
Contributor

Your external terminal is responsible this, not VS Code

@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants