Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to configure tsserver to use nodejs installed locally #172719

Closed
zen0wu opened this issue Jan 29, 2023 · 4 comments · Fixed by #191019
Closed

Option to configure tsserver to use nodejs installed locally #172719

zen0wu opened this issue Jan 29, 2023 · 4 comments · Fixed by #191019
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2023

Comments

@zen0wu
Copy link

zen0wu commented Jan 29, 2023

To get around the memory ceiling enforced by electron (#127105), how about we add an option to let us specify a nodejs installed locally (instead of relying on the builtin electron one).

The eslint plugin does this by having an option called eslint.runtime, so theoretically we could do the same, but not sure if I'm missing anything here.
@zen0wu
Copy link
Author

zen0wu commented Jan 29, 2023

The same has been proposed here: #151245 (comment)

@mjbvz mjbvz added feature-request Request for new features or functionality typescript Typescript support issues labels Jan 30, 2023
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Jan 30, 2023
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa modified the milestones: Backlog Candidates, Backlog Mar 29, 2023
@jakebailey jakebailey mentioned this issue Aug 18, 2023
Closed
@gabritto gabritto mentioned this issue Aug 22, 2023
Merged
@mjbvz mjbvz modified the milestones: Backlog, September 2023 Aug 29, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 6, 2023
@bhavyaus bhavyaus added the verification-needed Verification of issue is requested label Sep 26, 2023
@jrieken jrieken added the verified Verification succeeded label Sep 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2023
Development

Successfully merging a pull request may close this issue.

Add custom Node option to run TS Server gabritto/vscode
5 participants
@zen0wu @jrieken @mjbvz @bhavyaus @vscodenpa