Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pull diagnostics in JSON, HTML and CSS #150728

Closed
3 tasks done
aeschli opened this issue May 30, 2022 · 0 comments
Closed
3 tasks done

Test pull diagnostics in JSON, HTML and CSS #150728

aeschli opened this issue May 30, 2022 · 0 comments

Comments

@aeschli
Copy link
Contributor

aeschli commented May 30, 2022

Refs: #149643

Complexity: 2

Create Issue


The implementation of the CSS/HTML/JSON language servers has changed in how diagnostics are processed. They are now requested by VS Code instead of pushed by the language server. Nothing should change for the user.
This issue is to verify that all behaves normal

  • open a CSS/HTML/JSON file
  • create some error, you should see error squiggles being shown and an error shown in the problem view
  • fix the error, the squiggles are going away.
  • Note: HTML validates only happens in <script> and `<style> blocks, not for HTML tags or attributes
  • verify that only errors are shown on the problems view for editors that are open. Closing an editor should hide the errors
  • verify with errors diffs, in read-only editors such as git history.
@aeschli aeschli added this to the May 2022 milestone May 30, 2022
@dbaeumer dbaeumer removed their assignment May 31, 2022
@tanhakabir tanhakabir removed their assignment May 31, 2022
@bamurtaugh bamurtaugh removed their assignment May 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants