Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github: PR template picker needs polish #148323

Closed
joaomoreno opened this issue Apr 28, 2022 · 6 comments · Fixed by #151415
Closed

Github: PR template picker needs polish #148323

joaomoreno opened this issue Apr 28, 2022 · 6 comments · Fixed by #151415
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug github Github extension insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

From @joyceerhl in #143083 (comment)

I did get the list of PR templates:
image

However, I had no way to get back to the picker after taking that screenshot (which dismissed the picker). At minimum I feel we should use ignoreFocusOut: true, since the Create PR functionality is not exposed as a command palette command, I am stuck.

Additionally, after I selected a template to create the PR, nothing happened.

Finally, it was unexpected that I get two popups to create a PR when the GitHub Pull Requests and Issues extension is installed:
image

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug github Github extension labels Apr 28, 2022
@joaomoreno joaomoreno added this to the Backlog milestone Apr 28, 2022
@joaomoreno joaomoreno self-assigned this Apr 28, 2022
@joaomoreno
Copy link
Member Author

joaomoreno commented Apr 28, 2022

From what I can tell:

  • The PR list appears with full paths, each row should appear as a relative path from the repo root
  • @joyceerhl could only run the command once successfully
  • We should use ignoreFocusOut: true

Unsure of what to do about the simultaneous GHPR.


@babakks Would you like to tackle this in another PR?

@joaomoreno joaomoreno changed the title Github: PR Template picker needs polish Github: PR Template picker doesn't work and needs polish Apr 28, 2022
@joaomoreno joaomoreno changed the title Github: PR Template picker doesn't work and needs polish Github: PR template picker needs polish Apr 28, 2022
@babakks
Copy link
Contributor

babakks commented Apr 28, 2022

@joaomoreno Yes, I'll submit a PR.

@babakks
Copy link
Contributor

babakks commented Jun 7, 2022

@joaomoreno I've just submitted the PR. I forgot to create the PR at that time.

@joaomoreno joaomoreno modified the milestones: Backlog, June 2022 Jun 10, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 10, 2022
@meganrogge meganrogge added the verification-steps-needed Steps to verify are needed for verification label Jun 30, 2022
@connor4312 connor4312 added the verified Verification succeeded label Jul 1, 2022
@connor4312
Copy link
Member

Could not verify due to #143083 (comment). Maybe someone else will have better luck

@connor4312 connor4312 removed the verified Verification succeeded label Jul 1, 2022
@joaomoreno joaomoreno modified the milestones: June 2022, July 2022 Jul 3, 2022
@joaomoreno
Copy link
Member Author

Moving verification to July to account for #148568 (comment)

@joaomoreno joaomoreno removed the verification-steps-needed Steps to verify are needed for verification label Jul 24, 2022
@joaomoreno
Copy link
Member Author

Verification:

  1. Run Git: Clone and clone https://github.com/joaomoreno/test-pr-templates/
  2. Create a branch
  3. Make a change to README.md and commit
  4. Attempt to push/publish that branch. Code should tell you you can't push to that repo and will offer to fork the repository, accept.
  5. Code should then ask you whether you'd like to create a PR, accept.

The PR list should be polished.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2022
@andreamah andreamah added the verified Verification succeeded label Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug github Github extension insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants