Test decorations on gutter seem to have low contrast in Light High Contrast Theme

[luabud]

Testing #143425

If you open the test explorer and run tests that fail, the error icons on the gutter seem to have low contrast:

Same for when the tests pass:

Here's a repo that has tests enabled and configured: https://github.com/luabud/sample_project

[daviddossett]

Matched the colors used for success/error in other areas of the light HC theme.

For some reason it looks like these colors get somewhat dimmed in certain cases. Doesn't look related to this theme but I'll dig a little deeper and see if I can find out what's happening.

[daviddossett]

Subtle, but here's an example. It's ever-so-slightly faded before the tests have been run. @connor4312 does this sound familiar at all?

Before running tests

After running tests

[connor4312]

Yes, tests run before the current window are 'outdated' and are faded slightly. There used to be way for extensions to mark tests as outdated, but this is no longer a thing, so we could get rid of the outdated notion.

[daviddossett]

Yes, tests run before the current window are 'outdated' and are faded slightly. There used to be way for extensions to mark tests as outdated, but this is no longer a thing, so we could get rid of the outdated notion.

Ok great, thanks. Looks like removing this did the trick. I can push this if that's all to consider here:

vscode/src/vs/workbench/contrib/testing/browser/media/testing.css

Lines 68 to 71 in d4e2850

	.test-explorer .computed-state.retired,
	.testing-run-glyph.retired {
	opacity: 0.7 !important;
	}

[connor4312]

Please leave it for now, I'll clean it up as part of #144618

[daviddossett]

Sounds good, thank you!