Light HC theme missing watermark and keybindings hints

[roblourens]

Testing #143425

• Close all editors
• The logo watermark and keyboard shortcuts are missing, this is what it looks like in HC dark:

[daviddossett]

Dug into this a bit. It looks like there are two issues here:

First, we render different versions of the letterpress SVG depending on the theme type.

vscode/src/vs/workbench/browser/parts/editor/editorGroupView.ts

Line 1805 in 48010db

const letterpress = `./media/letterpress${theme.type === 'dark' ? '-dark' : theme.type === 'hc' ? '-hc' : ''}.svg`;

Second, our theme types are limited to dark, light, and hc.

vscode/src/vs/platform/theme/common/theme.ts

Lines 9 to 13 in e102191

	export enum ColorScheme {
	DARK = 'dark',
	LIGHT = 'light',
	HIGH_CONTRAST = 'hc'
	}

@aeschli what do you think about splitting the hc types into something like hc-dark and hc-light? I can see how this could create problems elsewhere since we probably rely on that broad hc type for all sorts of overrides.

Another option could be to rely on on a different field like theme.baseTheme, although that has other drawbacks.

cc @isidorn @misolori for awareness on the type splitting question above.

[daviddossett]

In the meantime I think can get by with using token vars e.g. fill:var(--vscode-foreground); in place of the hardcoded fill:white; in letterpress-hc.svg.

[daviddossett]

Fixed missing keybinding hints and updated the HC letterpress color to use a fixed hex value since it doesn't look like we can dynamically update the SVG's theme vars when the theme is changed.

[miguelsolorio]

@daviddossett don't forget the same file on distro for the branded icon versions if you haven't already gotten to it

[daviddossett]

Closing as fixed. Will create a separate issue for the theme type discussion.

[isidorn]

@daviddossett please ping me on that other issue. I think it makes hc-light, and hc-dark thought it might be quite some debt work. @aeschli would know best I think.