Introduce high contrast light theme

[kupatkar99]

GitHubTags:

#A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #Visual Studio Code Client; #BM-VisualStudioCode-Win32-Nov2021; #Win32; #HighContrast; #WCAG2.1#FTP; #STP; #AINotInScope;

Environment Details:

Application Name: Visual Studio Code Client
Windows Version: Windows 11

Repro Steps:

1. Turn on high contrast desert theme from settings.
2. Open Visual studio code editor
3. Using "Alt+H" key navigate to the "Help" menu bar option .
4. Using "Down" arrow key navigate to the "Welcome" item.
5. Make sure you have the following setting in settings.json: "workbench.startupEditor": "gettingStarted"
6. Using "Alt+H" navigate to "Help" menu bar option and use "down" arrow key to navigate to "Getting started".
7. Verify whether window is adapting the high contrast desert theme or not.

Actual Result:

Window is not adapting high contrast white theme when high contrast Desert theme is applied.

Expected Result:

Window should adapt the high contrast white theme when high contrast Desert theme is applied.

[JacksonKearl]

This is asking for general support for the variety of different high contrast themes windows supports. Currently we only have the one high contrast theme. cc @misolori and @isidorn any ideas on whether we will support many high contrast themes?

[miguelsolorio]

+@aeschli, I think we'd to have support in our theme & api structure. We already define a HC color in our color registry so that helps a bit.

But in general, we do not pickup the OS theme (specifically) but we do have the setting window.autoDetectColorScheme to detect dark/light/hc.

[aeschli]

The Windows High contrast themes consist of 6 different high contrast colors. We have many more colors in our color themes. Deriving a full theme from 6 colors is going to be difficult. If there are some combinations that don't work, if will make the theme useless.
So IMO the user is better served by color theme designed for VS Code.

That said, we should look into a light high contrast theme.

[isidorn]

Agree with last comment: let's just introduce a light high contrast theme.
I am assigning this to backlog and @misolori can assign to a milestone once there is a passionate designer that would like to add this.

fyi this issue is not from a user but from the testing team

[wesleyboar]

I have found these other requests/suggestions for at least a High Contrast Light Theme:

• Support highContrast attribute on DecorationRenderOptions #132955
• [themes] Accessibility: High Contrast White #134823
• Provide a light high contrast theme #100119

[isidorn]

I see this is on the February plan, thus let me assign it to the February milestone.
@daviddossett let me know how I can best help here. Or reach out to me if you would like to sync.

[daviddossett]

Thanks @isidorn. Working on the first version this week. Will share for feedback shortly 👍

[isidorn]

@daviddossett I tried this out, and this is a great start!
Can you please create a test plan item for this milestone so we get more eyes on it. Feel free to assign me as one of the testers. Thanks!

[daviddossett]

Thanks for taking a look! Test plan item is here.