Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start without debugging should not register breakpoints #129255

Closed
weinand opened this issue Jul 23, 2021 · 3 comments
Closed

Start without debugging should not register breakpoints #129255

weinand opened this issue Jul 23, 2021 · 3 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2021

Comments

@weinand
Copy link
Contributor

weinand commented Jul 23, 2021

VS Code should consider to skip the breakpoint registering DAP calls.
Even if a DA ignores the "noDebug" option it is somewhat surprising if it still breaks on breakpoints.
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Jul 23, 2021
@weinand weinand added this to the On Deck milestone Jul 23, 2021
@isidorn
Copy link
Contributor

isidorn commented Jul 27, 2021

I think this makes sense. Feel free to assign to August and I can look into this next milestone.

@weinand weinand modified the milestones: On Deck, August 2021 Jul 27, 2021
@isidorn isidorn closed this as completed in b3c2edb Aug 2, 2021
@isidorn
Copy link
Contributor

isidorn commented Aug 2, 2021

I have done the change that if we are Running without debugging we do not do any breakpoint calls.
This also includes exception breakpoints.

@weinand weinand removed the under-discussion Issue is under discussion for relevance, priority, approach label Aug 2, 2021
@weinand weinand added verification-needed Verification of issue is requested verified Verification succeeded labels Aug 23, 2021
@weinand
Copy link
Contributor Author

weinand commented Aug 25, 2021

@isidorn Works great!
With this change I could simplify Mock Debug because it is no longer necessary to protect many DAP request implementations from being run in "no-debug" mode.

@weinand weinand removed their assignment Aug 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

No branches or pull requests
3 participants
@weinand @isidorn and others