Migrating over settings for Code Actions on Save to Enums (#194345)

* migrating over from booleans to enums

* explicit not always

* cleaned up and removed unused comma

Author: justschen

src/vs/editor/browser/config/migrateOptions.ts

@@ -192,3 +192,18 @@ registerEditorSettingMigration('experimental.stickyScroll.maxLineCount', (value,
 		}
 	}
 });
+
+// Code Actions on Save
+registerEditorSettingMigration('codeActionsOnSave', (value, read, write) => {
+	if (value && typeof value === 'object') {
+		const newValue = {} as any;
+		for (const entry of Object.entries(value)) {
+			if (typeof entry[1] === 'boolean') {
+				newValue[entry[0]] = entry[1] ? 'explicit' : 'never';
+			} else {
+				newValue[entry[0]] = entry[1];
+			}
+		}
+		write(`codeActionsOnSave`, newValue);
+	}
+});

src/vs/workbench/contrib/codeActions/browser/codeActionsContribution.ts

@@ -48,9 +48,10 @@ const codeActionsOnSaveSchema: IConfigurationPropertySchema = {
 	markdownDescription: nls.localize('editor.codeActionsOnSave', 'Run CodeActions for the editor on save. CodeActions must be specified and the editor must not be shutting down. Example: `"source.organizeImports": "explicit" `'),
 	type: 'object',
 	additionalProperties: {
-		type: 'string'
+		type: 'string',
+		enum: ['always', 'never', 'explicit'],
 	},
-	default: {},
+	default: { 'source.fixAll': 'never', 'source.organizeImports': 'never', },
 	scope: ConfigurationScope.LANGUAGE_OVERRIDABLE,
 };