Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Update hello-world-angular sample to Angular versions ^15.0.0.0 #121

Closed
nelak2 opened this issue Dec 1, 2022 · 3 comments
Closed

Update hello-world-angular sample to Angular versions ^15.0.0.0 #121

nelak2 opened this issue Dec 1, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@nelak2
Copy link

nelak2 commented Dec 1, 2022

Describe the bug

When building the hello-world-angular sample per the instructions it fails as it is unable to resolve the Angular dependencies.

To reproduce

npx degit microsoft/vscode-webview-ui-toolkit-samples/frameworks/hello-world-angular hello-world
cd hello-world
npm run install:all <- Fails on this step
npm run build:webview
code .

Expected behavior

The sample project should build and run successfully

Screenshots

image

Desktop (please complete the following information):

  • OS Version: Windows 10 Home
  • Toolkit Version: npm 8.19.2

Additional context

Add any other context about the problem here.

@nelak2 nelak2 added the bug Something isn't working label Dec 1, 2022
@hawkticehurst
Copy link
Member

hawkticehurst commented Jan 20, 2023

Hey @nelak2, thanks for the bug report!

I looked into this during the last few weeks and found out that the problem likely has to do with a TypeScript versioning mismatch between what Angular v15 uses and what FAST uses (a technology we use to build the toolkit components).

See more of that discussion here.

It means that a fix for using the toolkit in Angular v15 might, unfortunately, take a while. In the meantime, however, I just merged a PR that (among other things) reverts the angular-hello-world sample back to using Angular v13.

@hawkticehurst
Copy link
Member

I will keep this issue open as a reminder to adopt a fix from FAST whenever it is released.

@hawkticehurst
Copy link
Member

Hi @nelak2!

Back with a final update: I'm very sorry to say that the toolkit is being deprecated and all development on these samples has come to a close.

There was an announcement earlier this week on the main toolkit repo where you can learn more details and leave any questions or comments you may have.

Beyond that, thank you so much filing this issue and apologies for never getting around to addressing it. It means a lot that you contributed to the improvement of this project. I wish you all the best in your future VS Code extension endeavors!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants