Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote-Containers commands do not receive selection objects from remote Docker extension #4405

Open
ucheNkadiCode opened this issue Feb 1, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers plan-review PM-highlighted item determined to be P1 or P2 upstream Issue identified as 'upstream' component related (exists outside of VS Code Remote)

Comments

@ucheNkadiCode
Copy link

ucheNkadiCode commented Feb 1, 2021

  • VSCode Version: 1.52.1
  • Local OS Version:
  • Remote OS Version:
  • Remote Extension/Connection: Docker + WSL 2

Steps to Reproduce:
Adding @paulyuk for repro steps

  1. From the Docker Extension, on the Volumes tab, when selecting a volume to Inspect in VS Code using the Remote Container extension, the Inspect in VS Code command fails.

Does this issue occur when you try this locally?: Yes
Does this issue occur when you try this locally and all extensions are disabled?: IDK

@github-actions github-actions bot added the containers Issue in vscode-remote containers label Feb 1, 2021
@chrmarti
Copy link
Contributor

chrmarti commented Feb 3, 2021

This is microsoft/vscode#111238 which has been closed with no fix.

To summarize: The Docker extension runs on the remote extension host inside WSL while the Remote-Containers extension runs on the local extension host on Windows. In this setup the selection from the Docker viewlet is not passed to the Remote-Containers command.

@chrmarti chrmarti self-assigned this Feb 3, 2021
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code Remote) labels Feb 3, 2021
@chrmarti
Copy link
Contributor

chrmarti commented Feb 3, 2021

A possible workaround would be to have the Docker extension offer a command to look up the current selection. When the Remote-Containers command is run with no selection passed, it would use that lookup command to get the volume name.

The same issue exists when trying to attach to a container from the Docker viewlet. There we open a container picker when the command does not receive a selection. So the user gets to pick the container twice which is not ideal.

@chrmarti chrmarti changed the title Inspect in VS Code does not work when in WSL 2 Remote-Containers commands do not receive selection objects from remote Docker extension Oct 29, 2021
@bamurtaugh bamurtaugh added the plan-review PM-highlighted item determined to be P1 or P2 label Apr 26, 2022
@markgrin
Copy link

I experience the same problem. Also I think it is an important problem, because fixing it would enable people to work with kubernetes\minikube in a WFH setting.

@mustanggb
Copy link

I have the problem after right clicking on a container and selecting Attach Visual Studio Code instead of attaching it opens another list Select the container to attach VS code and forces the same selection for a second time.

Very annoying.

The two lists aren't even in the same order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug containers Issue in vscode-remote containers plan-review PM-highlighted item determined to be P1 or P2 upstream Issue identified as 'upstream' component related (exists outside of VS Code Remote)
Projects
None yet
Development

No branches or pull requests

5 participants