Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Workspace in Container... improve support for multi root workspaces #387

Closed
Chuxel opened this issue May 20, 2019 · 6 comments
Closed
Assignees
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality on-testplan
Milestone

Comments

@Chuxel
Copy link
Member

Chuxel commented May 20, 2019

Currently opening a .codeworkspace in a container is a two step process. First you "Open Folder in Container", then File > Open Workspace (or by clicking the button in the toast that appears.)

This is partly because we do not currently support opening folders without a common root in a container or opening multiple containers at once. A workspace file could include multiple folders in entirely different parts of the local filesystem and each of these folders could have their own devcontainer.json files.

To start, we could support an open workspace command that is the equivalent of doing "Open Folder in Container" followed by "Open Workspace" but does not resolve these two limitations. Specifically it would:

  1. Look for a .devcontainer/devcontainer.json or .devcontainer.json file in the same folder as the .codeworkspace file.
  2. Mount this folder into the container and open the workspace. The .codeworkspace file would only be able to reference sub-folders.
@Chuxel Chuxel added containers Issue in vscode-remote containers feature-request Request for new features or functionality labels May 20, 2019
@egamma egamma changed the title Open Workspace in Container... command v1 (single container, sub-folders only) Open Workspace in Container... improve support for multi root workspaces May 21, 2019
@aeschli aeschli self-assigned this Jul 10, 2019
@aeschli aeschli added this to the July 2019 milestone Jul 10, 2019
@aeschli aeschli modified the milestones: July 2019, August 2019 Jul 30, 2019
@chrmarti chrmarti self-assigned this Aug 21, 2019
@chrmarti
Copy link
Contributor

One more assumption we make for the Docker Compose case is that the workspace file is inside the "workspaceFolder" given in the devcontainer.json. There is currently no other way to specify where the workspace file is mounted and the "workspaceFolder" property's name is not a great match. /cc @egamma @aeschli

@mtsmfm
Copy link

mtsmfm commented Sep 20, 2019

This issue doesn't allow us to open multiple containers in a single vscode window, correct?
If so, do you have any plan to have a container per directory?

@chrmarti
Copy link
Contributor

@mtsmfm That's correct.

@mtsmfm
Copy link

mtsmfm commented Sep 20, 2019

@chrmarti Can I open an issue for this feature request?

@chrmarti
Copy link
Contributor

@mtsmfm Yes, thanks.

@mtsmfm
Copy link

mtsmfm commented Sep 23, 2019

Opend

#1460

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

4 participants